From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: paulmck@linux.vnet.ibm.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: suspicious RCU usage (perf)
Date: Mon, 26 Aug 2013 13:50:12 -0400 [thread overview]
Message-ID: <20130826175012.GA25202@redhat.com> (raw)
In-Reply-To: <20130826133041.3d750b1b@gandalf.local.home>
On Mon, Aug 26, 2013 at 01:30:41PM -0400, Steven Rostedt wrote:
> > On Mon, Aug 26, 2013 at 10:58:38AM -0400, Dave Jones wrote:
> > > Another day, another rcu backtrace..
> > > This says rc6, but it's pretty darn close to rc7, I think it was running
> > > a build from Friday.
> >
> > Could you please send your .config? Also, were you running ftrace,
> > perf, RCU event tracing, or what?
> >
> > Looks like you are running ftrace, but I though Steven had set that
> > up so that it could be called from an extended quiescent state.
> >
>
> I know exactly what the issue is. Yes ftrace is safe to call even from
> these extended quiescent states, the problem is that ftrace is also the
> infrastructure of other users, where some of those users are not safe.
> Namely, perf.
>
> Right now perf is not safe to trace all functions, as some of those
> functions have this issue. I was going to add something like:
>
> FTRACE_NON_SAFE(rcu_eqs_enter);
>
> where it will record locations that are not safe for all users, such
> that unless a function registers to ftrace with a flag of
> "FTRACE_FL_NON_SAFE_OK", anything that is on the non safe list (from
> the macro) will not be traced.
>
> Now, how urgent is this fix? perf can only trace functions as root, and
> there's no reason for perf to be tracing all functions at the moment.
> But yes, a root user could run that and get this warning. Because I was
> going to implement this for 3.12 and not for this release.
This was triggered as a regular user fwiw.
I had not been running perf, or any other tracing. It was just left
fuzzing over the weekend with no interaction at all.
Dave
next prev parent reply other threads:[~2013-08-26 17:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 14:58 suspicious RCU usage (perf) Dave Jones
2013-08-26 16:29 ` Paul E. McKenney
2013-08-26 17:30 ` Steven Rostedt
2013-08-26 17:50 ` Dave Jones [this message]
2013-08-26 18:18 ` Steven Rostedt
2013-08-26 18:29 ` Dave Jones
2013-08-26 19:03 ` Steven Rostedt
2013-08-27 12:16 ` Peter Zijlstra
2013-08-30 15:49 ` Frederic Weisbecker
2013-08-30 15:52 ` Frederic Weisbecker
2013-08-30 15:59 ` Peter Zijlstra
2013-08-30 16:06 ` Frederic Weisbecker
2013-08-26 19:43 ` David Ahern
2013-08-26 19:49 ` Dave Jones
2013-08-27 13:10 ` Steven Rostedt
2013-08-27 13:58 ` David Ahern
2013-08-27 14:13 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826175012.GA25202@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox