From: Felipe Balbi <balbi@ti.com>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: <balbi@ti.com>, Julius Werner <jwerner@chromium.org>,
LKML <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Vivek Gautam <gautam.vivek@samsung.com>,
Praveen Paneri <p.paneri@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olofj@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree
Date: Tue, 27 Aug 2013 13:44:47 -0500 [thread overview]
Message-ID: <20130827184447.GR3005@radagast> (raw)
In-Reply-To: <CAHbNUh0Sa-atYMHbhEUX2vnVAcsdBJxw9RRzAp+6vqE8hi=p1w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Tue, Aug 13, 2013 at 02:11:27PM +0530, Tushar Behera wrote:
> On 12 July 2013 12:27, Felipe Balbi <balbi@ti.com> wrote:
> > Hi,
> >
> > On Wed, Jul 10, 2013 at 10:42:27AM -0700, Julius Werner wrote:
> >> Hi Felipe,
> >>
> >> This is intended to pull down a reset signal line, not to switch power
> >> to the device. I could implement that with the regulator framework
> >> too, but I think that would just be confusing and harder to understand
> >> without providing any benefit. It's really just a plain old GPIO.
> >
> > alright, in that case how about using drivers/reset/ ?
> >
>
> IIUC, reset-gpio driver only provides APIs for reset controls (reset,
> assert, deassert). We still need to find out the location from where
> we would be calling the reset function.
that's fair, but at least you reuse a bunch of boilerplate code to claim
the GPIO, set proper direction and value. No need to duplicate that in
your driver.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-27 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 0:34 [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree Julius Werner
2013-07-10 5:25 ` Felipe Balbi
2013-07-10 17:42 ` Julius Werner
2013-07-11 0:01 ` Fabio Estevam
2013-07-12 6:57 ` Felipe Balbi
2013-08-13 8:41 ` Tushar Behera
2013-08-27 18:44 ` Felipe Balbi [this message]
2013-08-28 3:55 ` Tushar Behera
2013-08-28 18:24 ` Julius Werner
2013-07-10 23:52 ` Jingoo Han
2013-07-11 21:46 ` Julius Werner
2013-07-12 0:48 ` Jingoo Han
2013-07-12 10:34 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827184447.GR3005@radagast \
--to=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=jwerner@chromium.org \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=p.paneri@samsung.com \
--cc=tushar.behera@linaro.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox