From: Felipe Balbi <balbi@ti.com>
To: Philippe De Swert <philippe.deswert@jollamobile.com>
Cc: <balbi@ti.com>, <linux-usb@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers
Date: Tue, 27 Aug 2013 13:55:06 -0500 [thread overview]
Message-ID: <20130827185506.GU3005@radagast> (raw)
In-Reply-To: <520C0741.3010905@jollamobile.com>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Thu, Aug 15, 2013 at 01:40:01AM +0300, Philippe De Swert wrote:
> Hi,
>
> On 12/08/13 21:08, Felipe Balbi wrote:
> >On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote:
> >>Some bad gadget drivers do not check the return status of usb_add_config.
> >
> >fix the gadget driver
>
> As stated in my comment (see below) that is indeed what should
> happen. But we cannot fix it in future new gadget drivers, is it thus
> not better
> to avoid a crash? The gadget driver will not work as expected anyway
> when this occurs and the print will at least give an indication why.
if we avoid a crash, we will be decreasing the urgency of fixing the
gadget driver bug.
Let's leave it as is. I can't live thinking that maybe in the future
there will be gadget drivers doing different things...
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-27 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:23 [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers Philippe De Swert
2013-08-12 18:08 ` Felipe Balbi
2013-08-14 22:40 ` Philippe De Swert
2013-08-27 18:55 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827185506.GU3005@radagast \
--to=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=philippe.deswert@jollamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox