From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@linaro.org>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>,
jslaby@suse.cz, matts@commtech-fastcom.com,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
dhowells@redhat.com, linux-serial@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] OMAP: UART: Keep the TX fifo full when possible
Date: Tue, 27 Aug 2013 16:03:48 -0700 [thread overview]
Message-ID: <20130827230348.GA5705@kroah.com> (raw)
In-Reply-To: <CAGa+x866vUhX-uctWfZpw42hW7bRTG92Qz=4j=gWL-vgpdryDg@mail.gmail.com>
On Tue, Aug 20, 2013 at 08:57:25AM -0700, Kevin Hilman wrote:
> + Felipe
>
> On Mon, Jul 8, 2013 at 3:04 AM, Alexander Savchenko
> <oleksandr.savchenko@ti.com> wrote:
> > From: Dmitry Fink <finik@ti.com>
> >
> > Current logic results in interrupt storm since the fifo
> > is constantly below the threshold level. Change the logic
> > to fill all the available spaces in the fifo as long as
> > we have data to minimize the possibilty of underflow and
> > elimiate excessive interrupts.
> >
> > Signed-off-by: Dmitry Fink <finik@ti.com>
> > Signed-off-by: Alexander Savchenko <oleksandr.savchenko@ti.com>
>
> Hmm, another OMAP serial patch that wasn't Cc'd to linux-omap where
> OMAP users might have seen it. :(
>
> I just bisected a strange problem in linux-next on OMAP3 down to this
> patch. Reverting it fixes the problem.
>
> On OMAP3530 Beagle and Overo, after boot, doing a 'cat /proc/cpuinfo'
> was not returning to a prompt, suggesting something strange with the
> FIFO. Hitting return gets me back to a prompt.
>
> Greg, this one should also be dropped from tty-next until it can be
> further investgated and the problem solved.
Now reverted, thanks.
greg k-h
next prev parent reply other threads:[~2013-08-27 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 10:04 [PATCH] OMAP: UART: Keep the TX fifo full when possible Alexander Savchenko
2013-08-20 15:57 ` Kevin Hilman
2013-08-27 14:32 ` Kevin Hilman
2013-08-27 23:03 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-07-03 10:40 Alexander Savchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827230348.GA5705@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dhowells@redhat.com \
--cc=jslaby@suse.cz \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matts@commtech-fastcom.com \
--cc=oleksandr.savchenko@ti.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox