From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@linaro.org>
Cc: Alexander Savchenko <oleksandr.savchenko@ti.com>,
jslaby@suse.cz, linux-serial@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ruchika Kharwar <ruchika@ti.com>,
balbi@ti.com
Subject: Re: [PATCH] serial: omap: Fix IRQ handling return value
Date: Tue, 27 Aug 2013 16:04:07 -0700 [thread overview]
Message-ID: <20130827230407.GA30462@kroah.com> (raw)
In-Reply-To: <CAGa+x84dE_RwN2G1y_9OJFxnq3JKq5g0YZd+mFueOjjvMzyyew@mail.gmail.com>
On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote:
> +Felipe
>
> On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> <oleksandr.savchenko@ti.com> wrote:
> > From: Ruchika Kharwar <ruchika@ti.com>
> >
> > Ensure the Interrupt handling routine return IRQ_HANDLED vs
> > IRQ_NONE.
>
> Why?
>
> By unconditionally returning IRQ_HANDLED, this patch will surely break
> systems where the UART IRQ is shared with other platforms.
>
> I just noticed this patch when bisecting a related problem. Why
> wasn't this Cc'd to linux-omap where OMAP users might have been more
> likely to see it?
>
> Greg, without a better justification in the changelog, I think this
> patch should be dropped from tty-next.
Now reverted, sorry for the delay.
greg k-h
prev parent reply other threads:[~2013-08-27 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 13:29 [PATCH] serial: omap: Fix IRQ handling return value Alexander Savchenko
2013-08-20 15:44 ` Kevin Hilman
2013-08-27 14:30 ` Kevin Hilman
2013-08-27 17:38 ` Greg KH
2013-08-27 23:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827230407.GA30462@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=jslaby@suse.cz \
--cc=khilman@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oleksandr.savchenko@ti.com \
--cc=ruchika@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox