* [PATCH] serial: omap: Fix IRQ handling return value
@ 2013-07-17 13:29 Alexander Savchenko
2013-08-20 15:44 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Savchenko @ 2013-07-17 13:29 UTC (permalink / raw)
To: gregkh, jslaby
Cc: linux-serial, linux-kernel, Ruchika Kharwar, Alexander Savchenko
From: Ruchika Kharwar <ruchika@ti.com>
Ensure the Interrupt handling routine return IRQ_HANDLED vs
IRQ_NONE.
Signed-off-by: Ruchika Kharwar <ruchika@ti.com>
Signed-off-by: Alexander Savchenko <oleksandr.savchenko@ti.com>
---
drivers/tty/serial/omap-serial.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index b6d1728..70feeb3 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -479,7 +479,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
struct uart_omap_port *up = dev_id;
unsigned int iir, lsr;
unsigned int type;
- irqreturn_t ret = IRQ_NONE;
int max_count = 256;
spin_lock(&up->port.lock);
@@ -490,7 +489,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
if (iir & UART_IIR_NO_INT)
break;
- ret = IRQ_HANDLED;
lsr = serial_in(up, UART_LSR);
/* extract IRQ type from IIR register */
@@ -529,7 +527,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
pm_runtime_put_autosuspend(up->dev);
up->port_activity = jiffies;
- return ret;
+ return IRQ_HANDLED;
}
static unsigned int serial_omap_tx_empty(struct uart_port *port)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: omap: Fix IRQ handling return value
2013-07-17 13:29 [PATCH] serial: omap: Fix IRQ handling return value Alexander Savchenko
@ 2013-08-20 15:44 ` Kevin Hilman
2013-08-27 14:30 ` Kevin Hilman
2013-08-27 23:04 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Hilman @ 2013-08-20 15:44 UTC (permalink / raw)
To: Alexander Savchenko
Cc: gregkh, jslaby, linux-serial, LKML, Ruchika Kharwar, balbi
+Felipe
On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
<oleksandr.savchenko@ti.com> wrote:
> From: Ruchika Kharwar <ruchika@ti.com>
>
> Ensure the Interrupt handling routine return IRQ_HANDLED vs
> IRQ_NONE.
Why?
By unconditionally returning IRQ_HANDLED, this patch will surely break
systems where the UART IRQ is shared with other platforms.
I just noticed this patch when bisecting a related problem. Why
wasn't this Cc'd to linux-omap where OMAP users might have been more
likely to see it?
Greg, without a better justification in the changelog, I think this
patch should be dropped from tty-next.
Kevin
> Signed-off-by: Ruchika Kharwar <ruchika@ti.com>
> Signed-off-by: Alexander Savchenko <oleksandr.savchenko@ti.com>
> ---
> drivers/tty/serial/omap-serial.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index b6d1728..70feeb3 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -479,7 +479,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
> struct uart_omap_port *up = dev_id;
> unsigned int iir, lsr;
> unsigned int type;
> - irqreturn_t ret = IRQ_NONE;
> int max_count = 256;
>
> spin_lock(&up->port.lock);
> @@ -490,7 +489,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
> if (iir & UART_IIR_NO_INT)
> break;
>
> - ret = IRQ_HANDLED;
> lsr = serial_in(up, UART_LSR);
>
> /* extract IRQ type from IIR register */
> @@ -529,7 +527,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
> pm_runtime_put_autosuspend(up->dev);
> up->port_activity = jiffies;
>
> - return ret;
> + return IRQ_HANDLED;
> }
>
> static unsigned int serial_omap_tx_empty(struct uart_port *port)
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: omap: Fix IRQ handling return value
2013-08-20 15:44 ` Kevin Hilman
@ 2013-08-27 14:30 ` Kevin Hilman
2013-08-27 17:38 ` Greg KH
2013-08-27 23:04 ` Greg KH
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2013-08-27 14:30 UTC (permalink / raw)
To: gregkh; +Cc: Alexander Savchenko, jslaby, linux-serial, LKML, balbi,
linux-omap
Greg,
On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman <khilman@linaro.org> wrote:
> +Felipe
>
> On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> <oleksandr.savchenko@ti.com> wrote:
>> From: Ruchika Kharwar <ruchika@ti.com>
>>
>> Ensure the Interrupt handling routine return IRQ_HANDLED vs
>> IRQ_NONE.
>
> Why?
>
> By unconditionally returning IRQ_HANDLED, this patch will surely break
> systems where the UART IRQ is shared with other platforms.
>
> I just noticed this patch when bisecting a related problem. Why
> wasn't this Cc'd to linux-omap where OMAP users might have been more
> likely to see it?
>
> Greg, without a better justification in the changelog, I think this
> patch should be dropped from tty-next.
Can you drop this from tty-next please?
The authors aren't responding (one of the ti.com addresses bounced)
and this "fix" is most is not correct.
Kevin
> Kevin
>
>> Signed-off-by: Ruchika Kharwar <ruchika@ti.com>
>> Signed-off-by: Alexander Savchenko <oleksandr.savchenko@ti.com>
>> ---
>> drivers/tty/serial/omap-serial.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
>> index b6d1728..70feeb3 100644
>> --- a/drivers/tty/serial/omap-serial.c
>> +++ b/drivers/tty/serial/omap-serial.c
>> @@ -479,7 +479,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
>> struct uart_omap_port *up = dev_id;
>> unsigned int iir, lsr;
>> unsigned int type;
>> - irqreturn_t ret = IRQ_NONE;
>> int max_count = 256;
>>
>> spin_lock(&up->port.lock);
>> @@ -490,7 +489,6 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
>> if (iir & UART_IIR_NO_INT)
>> break;
>>
>> - ret = IRQ_HANDLED;
>> lsr = serial_in(up, UART_LSR);
>>
>> /* extract IRQ type from IIR register */
>> @@ -529,7 +527,7 @@ static irqreturn_t serial_omap_irq(int irq, void *dev_id)
>> pm_runtime_put_autosuspend(up->dev);
>> up->port_activity = jiffies;
>>
>> - return ret;
>> + return IRQ_HANDLED;
>> }
>>
>> static unsigned int serial_omap_tx_empty(struct uart_port *port)
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: omap: Fix IRQ handling return value
2013-08-27 14:30 ` Kevin Hilman
@ 2013-08-27 17:38 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2013-08-27 17:38 UTC (permalink / raw)
To: Kevin Hilman
Cc: Alexander Savchenko, jslaby, linux-serial, LKML, balbi,
linux-omap
On Tue, Aug 27, 2013 at 07:30:19AM -0700, Kevin Hilman wrote:
> Greg,
>
>
> On Tue, Aug 20, 2013 at 8:44 AM, Kevin Hilman <khilman@linaro.org> wrote:
> > +Felipe
> >
> > On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> > <oleksandr.savchenko@ti.com> wrote:
> >> From: Ruchika Kharwar <ruchika@ti.com>
> >>
> >> Ensure the Interrupt handling routine return IRQ_HANDLED vs
> >> IRQ_NONE.
> >
> > Why?
> >
> > By unconditionally returning IRQ_HANDLED, this patch will surely break
> > systems where the UART IRQ is shared with other platforms.
> >
> > I just noticed this patch when bisecting a related problem. Why
> > wasn't this Cc'd to linux-omap where OMAP users might have been more
> > likely to see it?
> >
> > Greg, without a better justification in the changelog, I think this
> > patch should be dropped from tty-next.
>
> Can you drop this from tty-next please?
>
> The authors aren't responding (one of the ti.com addresses bounced)
> and this "fix" is most is not correct.
Yes, sorry, behind on my pending tty patch queue. I'll try to get to it
this week.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] serial: omap: Fix IRQ handling return value
2013-08-20 15:44 ` Kevin Hilman
2013-08-27 14:30 ` Kevin Hilman
@ 2013-08-27 23:04 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2013-08-27 23:04 UTC (permalink / raw)
To: Kevin Hilman
Cc: Alexander Savchenko, jslaby, linux-serial, LKML, Ruchika Kharwar,
balbi
On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote:
> +Felipe
>
> On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
> <oleksandr.savchenko@ti.com> wrote:
> > From: Ruchika Kharwar <ruchika@ti.com>
> >
> > Ensure the Interrupt handling routine return IRQ_HANDLED vs
> > IRQ_NONE.
>
> Why?
>
> By unconditionally returning IRQ_HANDLED, this patch will surely break
> systems where the UART IRQ is shared with other platforms.
>
> I just noticed this patch when bisecting a related problem. Why
> wasn't this Cc'd to linux-omap where OMAP users might have been more
> likely to see it?
>
> Greg, without a better justification in the changelog, I think this
> patch should be dropped from tty-next.
Now reverted, sorry for the delay.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-08-27 23:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 13:29 [PATCH] serial: omap: Fix IRQ handling return value Alexander Savchenko
2013-08-20 15:44 ` Kevin Hilman
2013-08-27 14:30 ` Kevin Hilman
2013-08-27 17:38 ` Greg KH
2013-08-27 23:04 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox