public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] power/reset: Make vexpress driver depend on required infrastructure
       [not found] <20130815114401.GD23006@n2100.arm.linux.org.uk>
@ 2013-08-15 15:35 ` Pawel Moll
  2013-08-28  1:35   ` Anton Vorontsov
  0 siblings, 1 reply; 2+ messages in thread
From: Pawel Moll @ 2013-08-15 15:35 UTC (permalink / raw)
  To: Anton Vorontsov, David Woodhouse
  Cc: linux-kernel, linux-arm-kernel, Russell King - ARM Linux,
	Pawel Moll

ARM Versatile Express reset driver requires platform-specific
config infrastructure to be present in the kernel. When
VEXPRESS_CONFIG is not selected, the build will fail like this:

drivers/built-in.o: In function `vexpress_reset_do.clone.0':
iio-trig-interrupt.c:(.text+0x1aff38): undefined reference to `__vexpress_config_func_get'
iio-trig-interrupt.c:(.text+0x1aff4c): undefined reference to `vexpress_config_write'

Added required dependency to the Kconfig entry.

Signed-off-by: Pawel Moll <pawel.moll@arm.com>
---
 drivers/power/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index ee039dc..26d79df 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -34,7 +34,7 @@ config POWER_RESET_RESTART
 config POWER_RESET_VEXPRESS
 	bool "ARM Versatile Express power-off and reset driver"
 	depends on ARM || ARM64
-	depends on POWER_RESET
+	depends on POWER_RESET && VEXPRESS_CONFIG
 	help
 	  Power off and reset support for the ARM Ltd. Versatile
 	  Express boards.
-- 
1.8.1.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power/reset: Make vexpress driver depend on required infrastructure
  2013-08-15 15:35 ` [PATCH] power/reset: Make vexpress driver depend on required infrastructure Pawel Moll
@ 2013-08-28  1:35   ` Anton Vorontsov
  0 siblings, 0 replies; 2+ messages in thread
From: Anton Vorontsov @ 2013-08-28  1:35 UTC (permalink / raw)
  To: Pawel Moll
  Cc: David Woodhouse, linux-kernel, linux-arm-kernel,
	Russell King - ARM Linux

On Thu, Aug 15, 2013 at 04:35:52PM +0100, Pawel Moll wrote:
> ARM Versatile Express reset driver requires platform-specific
> config infrastructure to be present in the kernel. When
> VEXPRESS_CONFIG is not selected, the build will fail like this:
> 
> drivers/built-in.o: In function `vexpress_reset_do.clone.0':
> iio-trig-interrupt.c:(.text+0x1aff38): undefined reference to `__vexpress_config_func_get'
> iio-trig-interrupt.c:(.text+0x1aff4c): undefined reference to `vexpress_config_write'
> 
> Added required dependency to the Kconfig entry.
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

Applied, thanks!

Anton

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-08-28  1:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20130815114401.GD23006@n2100.arm.linux.org.uk>
2013-08-15 15:35 ` [PATCH] power/reset: Make vexpress driver depend on required infrastructure Pawel Moll
2013-08-28  1:35   ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox