public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Christian Ruppert <christian.ruppert@abilis.com>,
	Shinya Kuribayashi <skuribay@pobox.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c-designware: make HCNT/LCNT values configurable
Date: Wed, 28 Aug 2013 11:10:19 +0200	[thread overview]
Message-ID: <20130828091019.GD4086@katana> (raw)
In-Reply-To: <1376914074-31103-1-git-send-email-mika.westerberg@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

On Mon, Aug 19, 2013 at 03:07:53PM +0300, Mika Westerberg wrote:
> The DesignWare I2C controller has high count (HCNT) and low count (LCNT)
> registers for each of the I2C speed modes (standard and fast). These
> registers are programmed based on the input clock speed in the driver.
> 
> The current code calculates these values based on the input clock speed and
> tries hard to meet the I2C bus timing requirements. This could result
> non-optimal values with regarding to the bus speed. For example on Intel
> BayTrail we get bus speed of 315.41kHz which is ~20% slower than we would
> expect (400kHz) in fast mode (even though the timing requirements are met).
> 
> This patch makes it possible for the platform code to pass more optimal
> HCNT/LCNT values to the core driver if they are known beforehand. If these
> are not set we use the calculated and more conservative values.
> 
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2013-08-28  9:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 12:07 [PATCH v2 1/2] i2c-designware: make HCNT/LCNT values configurable Mika Westerberg
2013-08-19 12:07 ` [PATCH v2 2/2] i2c-designware: get SDA hold time, HCNT and LCNT configuration from ACPI Mika Westerberg
2013-08-28  9:10   ` Wolfram Sang
2013-08-19 12:40 ` [PATCH v2 1/2] i2c-designware: make HCNT/LCNT values configurable Shinya Kuribayashi
2013-08-28  9:10 ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130828091019.GD4086@katana \
    --to=wsa@the-dreams.de \
    --cc=christian.ruppert@abilis.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=skuribay@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox