Re: [PATCH 4/5] ARM: tegra: Add host1x, dc and hdmi to Tegra114 device tree

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

On Wed, Aug 28, 2013 at 01:40:58PM +0300, Mikko Perttunen wrote:
> Add host1x, dc (display controller) and hdmi devices to Tegra114
> device tree.

"DC" and "HDMI".

> 
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
>  arch/arm/boot/dts/tegra114.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> index 2905145..ce5a95c 100644
> --- a/arch/arm/boot/dts/tegra114.dtsi
> +++ b/arch/arm/boot/dts/tegra114.dtsi
> @@ -27,6 +27,49 @@
>  			(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
>  	};
>  
> +	host1x {
> +		compatible = "nvidia,tegra114-host1x", "nvidia,tegra30-host1x",

I don't think that's correct. The Tegra114 host1x is not backwards
compatible with the Tegra30 host1x.

That said, I have a local patch that is a bit more complete in that it
adds other host1x devices as listed in the TRM as well. But I'll leave
it up to Stephen how he prefers to handle that. It should be fine to
defer adding nodes for additional hardware blocks when the supporting
drivers are merged. We've done it for other devices as well.

> +				"simple-bus";
> +		reg = <0x50000000 0x00028000>;
> +		interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>,
> +				<GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;

I think this should be indented with the previous line. Also other SoC
.dtsi files use a single entry, as in:

		interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH
			      GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;

> +		hdmi {
> +			compatible = "nvidia,tegra114-hdmi";
> +			reg = <0x54280000 0x00040000>;
> +			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&tegra_car TEGRA114_CLK_HDMI>,
> +				    <&tegra_car TEGRA114_CLK_PLL_D_OUT0>;

Any reason why we can't use pll_d2_out0 here, like we do on Tegra30?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]