From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Gaurav <kumargauravgupta3@gmail.com>
Cc: sarah.a.sharp@linux.intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call
Date: Wed, 28 Aug 2013 22:15:00 +0300 [thread overview]
Message-ID: <20130828191500.GH19256@mwanda> (raw)
In-Reply-To: <521E1292.5060709@gmail.com>
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote:
> On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote:
> >On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote:
> >>This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument.
> >>Hence there is no need of keeping it in the function arguments.
> >>
> >>Redefining this function breaks other functions which calls this function.
> >>This phatch also correct those calls in xhci driver.
> >>
> >>Signed-off-by: Kumar Gaurav <kumargauravgupta3@gmail.com>
> >>---
> >Could you put a list of changes since v2 here?:
> >
> >v3: blah blah changelog mostly.
> >
> >Also this doesn't apply for me against linux-next.
> >
> >regards,
> >dan carpenter
> >
> There's no change from v2. I was sending the same patch again
> because the last one was lacking good description and i was told (or
> as i understood) that if I'm sending the same patch or patch for the
> same purpose as previous then i should increment version so i did.
Put:
v2: no change. just the changelog.
Otherwise we have to look for the change.
>
> I had developed this patch against linux-git, haven't tested that on
> linux-next as i haven't cloned linux-next yet.
>
> I've started cloning linux-next and as it's not applying on
> linux-next, I'll try it on linux-next (once i cloned it) and will
> send again.
Yep. Cleanups should be done against linux-next.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-28 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 2:08 [PATCH v3] xHCI: Fixing xhci_readl definition and function call Kumar Gaurav
2013-08-28 7:13 ` Dan Carpenter
2013-08-28 15:09 ` Kumar Gaurav
2013-08-28 17:01 ` Sarah Sharp
2013-08-28 17:15 ` Kumar Gaurav
2013-08-28 17:35 ` Sarah Sharp
2013-08-28 19:15 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-22 3:04 Kumar Gaurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828191500.GH19256@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumargauravgupta3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox