From: "Heiko Stübner" <heiko@sntech.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Axel Lin <axel.lin@ingics.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: rockchip: Implement .request() and .free() callbacks on the GPIO chips
Date: Thu, 29 Aug 2013 01:03:44 +0200 [thread overview]
Message-ID: <201308290103.45003.heiko@sntech.de> (raw)
In-Reply-To: <CACRpkdbJMG-MbBrt19kj_NTrarhcHfDCppciuL93fT95Mby7MA@mail.gmail.com>
Am Mittwoch, 28. August 2013, 13:25:57 schrieb Linus Walleij:
> On Tue, Aug 27, 2013 at 4:30 PM, Axel Lin <axel.lin@ingics.com> wrote:
> > Implement .request() and .free() callbacks on the GPIO chips to inform
> > pinctrl when a GPIO is requested or freed.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
>
> Ohhh that will have semantic effects so really need to wait
> for Heiko's opinion on this one.
I don't see any showstoppers here. Tested it on my machine with gpio-keys
without any issues popping up. So
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Heiko
next prev parent reply other threads:[~2013-08-28 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 14:30 [PATCH] pinctrl: rockchip: Implement .request() and .free() callbacks on the GPIO chips Axel Lin
2013-08-28 11:25 ` Linus Walleij
2013-08-28 13:06 ` Axel Lin
2013-08-28 23:03 ` Heiko Stübner [this message]
2013-08-29 7:11 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308290103.45003.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=axel.lin@ingics.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox