From: Frederic Weisbecker <fweisbec@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nohz: put proper symbol in the unstable schedclock warning
Date: Fri, 30 Aug 2013 13:38:27 +0200 [thread overview]
Message-ID: <20130830113826.GD7806@somewhere> (raw)
In-Reply-To: <alpine.LNX.2.00.1308051420290.17512@pobox.suse.cz>
On Mon, Aug 05, 2013 at 02:21:13PM +0200, Jiri Kosina wrote:
> Since e12d0271 ("nohz: Warn if the machine can not perform nohz_full")
> Kernel triggers a WARN() in case sched clock is marked as unstable.
>
> Make it output a proper Kconfig symbol (NO_HZ_FULL) when informing user
> about this.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
I'm queuing this, thanks!
> ---
> kernel/time/tick-sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index e77edc9..e0030ed 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -182,7 +182,7 @@ static bool can_stop_full_tick(void)
> * Don't allow the user to think they can get
> * full NO_HZ with this machine.
> */
> - WARN_ONCE(1, "NO_HZ FULL will not work with unstable sched clock");
> + WARN_ONCE(1, "NO_HZ_FULL will not work with unstable sched clock");
> return false;
> }
> #endif
>
> --
> Jiri Kosina
> SUSE Labs
prev parent reply other threads:[~2013-08-30 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 12:21 [PATCH] nohz: put proper symbol in the unstable schedclock warning Jiri Kosina
2013-08-30 11:38 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830113826.GD7806@somewhere \
--to=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox