public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: linux-kernel@vger.kernel.org, airlied@redhat.com,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/2] vgaarb: Fixes for partial VGA opt-out
Date: Fri, 30 Aug 2013 15:41:19 +0300	[thread overview]
Message-ID: <20130830124119.GH11428@intel.com> (raw)
In-Reply-To: <20130815222835.27642.15330.stgit@bling.home>

On Thu, Aug 15, 2013 at 04:37:47PM -0600, Alex Williamson wrote:
> I'm trying to add support for VGA arbitration on newer Intel graphics
> devices.  The existing code attempts to do this, but appear to have
> not been updated since GMCH devices roamed the Earth.  On newer
> devices like Haswell, we can disable VGA memory through an MSR on the
> device, but we rely on the VGA arbiter to manage VGA IO using the PCI
> COMMAND register.  In trying to unregister legacy VGA memory, I found
> that the VGA arbiter still wanted to disable both memory and IO on
> the device and that it forgot to actually program the device to
> disable IO when the decoding is updated.  This series attempts to fix
> both of those.  Thanks,

The series looks good to me.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> 
> Alex
> 
> ---
> 
> Alex Williamson (2):
>       vgaarb: Don't disable resources that are not owned
>       vgaarb: Fix VGA decodes changes
> 
> 
>  drivers/gpu/vga/vgaarb.c |   50 ++++++++++++++++++++--------------------------
>  1 file changed, 22 insertions(+), 28 deletions(-)

-- 
Ville Syrjälä
Intel OTC

  parent reply	other threads:[~2013-08-30 12:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 22:37 [PATCH 0/2] vgaarb: Fixes for partial VGA opt-out Alex Williamson
2013-08-15 22:37 ` [PATCH 1/2] vgaarb: Don't disable resources that are not owned Alex Williamson
2013-08-15 22:37 ` [PATCH 2/2] vgaarb: Fix VGA decodes changes Alex Williamson
2013-08-30 12:41 ` Ville Syrjälä [this message]
2013-09-02  6:19   ` [Intel-gfx] [PATCH 0/2] vgaarb: Fixes for partial VGA opt-out Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130830124119.GH11428@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox