* Re: rcu: Make rcu_assign_pointer's assignment volatile and type-safe
[not found] <5223d2b1.W0Uf1KjUIaBOcCMH%wangshilong1991@gmail.com>
@ 2013-09-02 0:06 ` Josh Triplett
0 siblings, 0 replies; only message in thread
From: Josh Triplett @ 2013-09-02 0:06 UTC (permalink / raw)
To: Wang Shilong
Cc: linux-kernel, linux-sparse, sparse, lttng-dev, Stephen Hemminger,
Paul E. McKenney, Mathieu Desnoyers, Andy Whitcroft, Joe Perches
On Mon, Sep 02, 2013 at 07:50:09AM +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
> WARNING: line over 80 characters
> #57: FILE: include/linux/rcupdate.h:518:
> + extern void __rcu_assign_pointer_typecheck(int, typeof(*(v)) __kernel *); \
It'd get much uglier if wrapped, and the function name needs to stay
unique to avoid conflicts with the macro context. I don't plan to
change this.
> ERROR: need consistent spacing around '*' (ctx:WxB)
> #72: FILE: include/linux/rcupdate.h:568:
> + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \
False positive; checkpatch.pl seems to parse this as multiplication
rather than a cast.
- Josh Triplett
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-02 0:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5223d2b1.W0Uf1KjUIaBOcCMH%wangshilong1991@gmail.com>
2013-09-02 0:06 ` rcu: Make rcu_assign_pointer's assignment volatile and type-safe Josh Triplett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox