From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
David Howells <dhowells@redhat.com>,
ksummit-2013-discuss@lists.linuxfoundation.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: Add warning about submitting patches using --file
Date: Mon, 2 Sep 2013 23:37:05 +0300 [thread overview]
Message-ID: <20130902203705.GN19256@mwanda> (raw)
In-Reply-To: <1378150847.1953.106.camel@joe-AO722>
On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote:
> +WARNING: When using --file mode, do not send patches that just make
> +whitespace or formatting changes unless more significant changes are
> +also made for other reasons in another patch.
> +
This is a run on sentence. Also I don't agree with it. Clean up
patches are good on their own. There are parts of the kernel which are
not just in staging where I refuse to look at because it is so bad.
The problem is that people send "clean up" patches which don't clean up
the code or which make the code worse than the original. All they care
about is pleasing checkpatch.pl instead of actually thinking about what
they are doing. The message should just say something like, "Take a
step back and think about if this actually improves things for human
readers."
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-02 20:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9976.1378132260@warthog.procyon.org.uk>
2013-09-02 16:10 ` Making changes to the Coding Style Joe Perches
2013-09-02 18:15 ` [Ksummit-2013-discuss] " Josh Triplett
2013-09-02 18:19 ` [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle Josh Triplett
2013-09-02 18:39 ` [Ksummit-2013-discuss] " Mauro Carvalho Chehab
2013-09-02 18:59 ` Joe Perches
2013-09-02 19:48 ` Mauro Carvalho Chehab
2013-09-02 19:50 ` Josh Triplett
2013-09-02 20:04 ` Guenter Roeck
2013-09-02 22:14 ` [PATCH] checkpatch: Report missing spaces around trigraphs with --strict Joe Perches
2013-09-02 23:15 ` Josh Triplett
2013-09-02 23:54 ` Joe Perches
2013-09-03 0:32 ` Josh Triplett
2013-09-02 20:50 ` [Ksummit-2013-discuss] [PATCH] checkpatch: Add comment about updating Documentation/CodingStyle David Howells
2013-09-02 21:11 ` Joe Perches
2013-09-03 0:26 ` Shilong Wang
2013-09-03 0:36 ` Josh Triplett
2013-09-03 1:21 ` Fengguang Wu
2013-09-03 0:39 ` Fengguang Wu
2013-09-03 0:47 ` Joe Perches
2013-09-03 1:35 ` Fengguang Wu
2013-09-03 1:34 ` Josh Triplett
2013-09-03 1:52 ` Joe Perches
2013-09-03 2:12 ` Josh Triplett
2013-09-03 2:21 ` Joe Perches
2013-09-03 2:46 ` Fengguang Wu
2013-09-03 3:16 ` Josh Triplett
2013-09-03 3:22 ` Fengguang Wu
2013-09-03 18:09 ` Bjorn Helgaas
2013-09-04 0:49 ` Fengguang Wu
2013-09-02 22:08 ` Josh Triplett
2013-09-02 19:34 ` Josh Triplett
2013-09-02 19:40 ` [PATCH] checkpatch: Add warning about submitting patches using --file Joe Perches
2013-09-02 19:54 ` [Ksummit-2013-discuss] " Mauro Carvalho Chehab
2013-09-02 19:56 ` Josh Triplett
2013-09-02 20:37 ` Dan Carpenter [this message]
2013-09-02 21:51 ` Joe Perches
2013-09-17 21:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130902203705.GN19256@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dhowells@redhat.com \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=ksummit-2013-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox