Re: [PATCH 1/2] gpio: Fix crash in gpiod_set_debounce()

Linus Walleij
2013-09-06T08:55:45Z

On Tue, Sep 3, 2013 at 10:25 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:

>> chip = desc->chip;
>> if (!chip->set || !chip->set_debounce) {
>> pr_warn("%s: missing set() or set_debounce() operations\n",
>> __func__);
>> + return -EIO;
>> }
>
> BTW, I'm not sure that error-path should pr_warn(). For example, if this
> error-patch is taken due to a call from
> gpio_keys.c:gpio_keys_setup_key(), then a timer will be used for
> debounce instead, which is all perfectly valid, and probably not
> something that should be spewed to the kernel log.

You're right, I wasn't aware of the fallback use-case,
so I've proposed a separate patch fixing this.

Yours,
Linus Walleij