From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754888Ab3ICOiQ (ORCPT ); Tue, 3 Sep 2013 10:38:16 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:34296 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752467Ab3ICOiP (ORCPT ); Tue, 3 Sep 2013 10:38:15 -0400 Date: Tue, 3 Sep 2013 06:54:22 -0700 From: "Paul E. McKenney" To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Peter Zijlstra , Frederic Weisbecker , Jiri Olsa Subject: Re: [RFC][PATCH 03/18 v2] ftrace: Set ftrace internal function tracing RCU safe Message-ID: <20130903135422.GO3871@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20130831051117.884125230@goodmis.org> <20130831051700.928372852@goodmis.org> <20130831194431.GK3871@linux.vnet.ibm.com> <20130903092224.2ca84f5f@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130903092224.2ca84f5f@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13090314-0928-0000-0000-000001391212 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 03, 2013 at 09:22:24AM -0400, Steven Rostedt wrote: > On Sat, 31 Aug 2013 12:44:31 -0700 > "Paul E. McKenney" wrote: > > > On Sat, Aug 31, 2013 at 01:11:20AM -0400, Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > > > Since none of the internal ftrace function tracing uses RCU in > > > their callbacks, it is OK to set the global_ops (the one that > > > they all use) to RCU safe. > > > > > > Cc: Jiri Olsa > > > Cc: Paul E. McKenney > > > Signed-off-by: Steven Rostedt > > > > Acked-by: Paul E. McKenney > > You must have liked this patch so much... that you acked it twice ;-) Better safe than sorry? No, that doesn't sound quite right... Thanx, Paul > -- Steve > > > > > > --- > > > kernel/trace/ftrace.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > > index d61f431..a45deaa 100644 > > > --- a/kernel/trace/ftrace.c > > > +++ b/kernel/trace/ftrace.c > > > @@ -1146,7 +1146,9 @@ static struct ftrace_ops global_ops = { > > > .func = ftrace_stub, > > > .notrace_hash = EMPTY_HASH, > > > .filter_hash = EMPTY_HASH, > > > - .flags = FTRACE_OPS_FL_RECURSION_SAFE | FTRACE_OPS_FL_INITIALIZED, > > > + .flags = FTRACE_OPS_FL_RECURSION_SAFE | > > > + FTRACE_OPS_FL_INITIALIZED | > > > + FTRACE_OPS_FL_RCU_SAFE, > > > INIT_REGEX_LOCK(global_ops) > > > }; > > > > > > -- > > > 1.7.10.4 > > > > > > >