From: Greg KH <gregkh@linuxfoundation.org>
To: Dave Jones <davej@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
rmk+kernel@arm.linux.org.uk
Subject: Re: kobject: delayed kobject release: help find buggy drivers
Date: Tue, 3 Sep 2013 13:55:27 -0700 [thread overview]
Message-ID: <20130903205527.GA6358@kroah.com> (raw)
In-Reply-To: <20130903204442.GA22222@redhat.com>
On Tue, Sep 03, 2013 at 04:44:42PM -0400, Dave Jones wrote:
> On Tue, Sep 03, 2013 at 06:59:24PM +0000, Linux Kernel wrote:
> > Gitweb: http://git.kernel.org/linus/;a=commit;h=c817a67ecba7c3c2aaa104796d78f160af60920d
> > Commit: c817a67ecba7c3c2aaa104796d78f160af60920d
> > Parent: 7c42721fe0c58a848849b43ff558cf2fb86aa35a
> > Author: Russell King <rmk+kernel@arm.linux.org.uk>
> > AuthorDate: Thu Jun 27 15:06:14 2013 +0100
> > Committer: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > CommitDate: Thu Jul 25 15:39:04 2013 -0700
> >
> > kobject: delayed kobject release: help find buggy drivers
> >
> > Implement debugging for kobject release functions. kobjects are
> > reference counted, so the drop of the last reference to them is not
> > predictable. However, the common case is for the last reference to be
> > the kobject's removal from a subsystem, which results in the release
> > function being immediately called.
> >
> > This can hide subtle bugs, which can occur when another thread holds a
> > reference to the kobject at the same time that a kobject is removed.
> > This results in the release method being delayed.
> >
> > In order to make these kinds of problems more visible, the following
> > patch implements a delayed release; this has the effect that the
> > release function will be out of order with respect to the removal of
> > the kobject in the same manner that it would be if a reference was
> > being held.
> >
> > This provides us with an easy way to allow driver writers to debug
> > their drivers and fix otherwise hidden problems.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> With this enabled, I get a bunch of scrolling oopses immediately after
> exiting the bootloader. It happens so early I can't even capture them
> over usb-serial, or earlyprintk=dbgp.
>
> And for whatever reason, the printk path while oopsing ignores boot_delay parameter,
> so I can't even use that.
>
> any ideas ?
The first big bug found with this was with the module kobject code, and
a fix for that should be going in through Rusty's tree to Linus for this
merge window (right Rusty?)
After that, things should settle down and boot properly, although a few
bugs have been reported already to their respective subsystem owners, I
don't know the status of them yet.
thanks,
greg k-h
next prev parent reply other threads:[~2013-09-03 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130903185924.046EE660E91@gitolite.kernel.org>
2013-09-03 20:44 ` kobject: delayed kobject release: help find buggy drivers Dave Jones
2013-09-03 20:55 ` Greg KH [this message]
2013-09-04 5:23 ` Rusty Russell
2013-09-05 4:13 ` Dave Jones
2013-09-05 4:57 ` Greg KH
2013-09-05 5:00 ` Dave Jones
2013-09-05 5:19 ` Dave Jones
2013-09-05 15:34 ` Greg KH
2013-09-05 15:47 ` Dave Jones
2013-09-05 17:35 ` Russell King - ARM Linux
2013-09-05 18:13 ` Dave Jones
2013-09-05 19:29 ` Dave Jones
2013-09-05 21:11 ` Dave Jones
2013-09-05 21:26 ` Dave Jones
2013-09-05 21:44 ` Russell King - ARM Linux
2013-09-06 1:11 ` Dave Jones
2013-09-06 7:59 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903205527.GA6358@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox