public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	john453@faraday-tech.com
Subject: Re: usb: host: Faraday fotg210-hcd driver
Date: Tue, 3 Sep 2013 17:32:05 -0400	[thread overview]
Message-ID: <20130903213205.GA7433@redhat.com> (raw)
In-Reply-To: <20130903212355.GA12978@kroah.com>

On Tue, Sep 03, 2013 at 02:23:55PM -0700, Greg KH wrote:

 > >  > +config USB_FOTG210_HCD
 > >  > +	tristate "FOTG210 HCD support"
 > >  > +	depends on USB
 > >  > +	default N
 > >  > +	---help---
 > >  > +	  Faraday FOTG210 is an OTG controller which can be configured as
 > >  > +	  an USB2.0 host. It is designed to meet USB2.0 EHCI specification
 > >  > +	  with minor modification.
 > >  > +
 > >  > +	  To compile this driver as a module, choose M here: the
 > >  > +	  module will be called fotg210-hcd.
 > >  > +
 > > 
 > > Shouldn't this depend on USB_OTG ?
 > > Seems odd to have OTG related options presented to me when I have that unset.
 > 
 > It's a USB Host controller, so it should be built if you have that
 > option set.  The fact that it can do OTG isn't an issue here, from what
 > I can tell.

Ok. It still likely needs a 'depends on $ARCH (arm?) | COMPILE_TEST' though.

	Dave

PS: What happened with this driver ?

This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <yhchen@faraday-tech.com>
and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <john453@faraday-tech.com>

Given the former address seems to be broken, perhaps all those mentions of it
in the faraday sources need updating ?

----- The following addresses had permanent fatal errors -----
<yhchen@faraday-tech.com>
    (reason: 553 5.1.3 <yhchen@faraday-tech.com>... Check FTC account failure!<2>)

   ----- Transcript of session follows -----
... while talking to mailhost1.faraday-tech.com.:
>>> DATA
<<< 553 5.1.3 <yhchen@faraday-tech.com>... Check FTC account failure!<2>
550 5.1.1 <yhchen@faraday-tech.com>... User unknown
<<< 503 5.0.0 Need RCPT (recipient)


  reply	other threads:[~2013-09-03 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130903185912.A59316601F4@gitolite.kernel.org>
2013-09-03 21:15 ` usb: host: Faraday fotg210-hcd driver Dave Jones
2013-09-03 21:23   ` Greg KH
2013-09-03 21:32     ` Dave Jones [this message]
2013-09-03 21:40       ` Greg KH
2013-09-03 21:46         ` Dave Jones
2013-09-03 22:02           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903213205.GA7433@redhat.com \
    --to=davej@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=john453@faraday-tech.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox