From: Dave Jones <davej@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john453@faraday-tech.com
Subject: Re: usb: host: Faraday fotg210-hcd driver
Date: Tue, 3 Sep 2013 17:46:26 -0400 [thread overview]
Message-ID: <20130903214626.GA10542@redhat.com> (raw)
In-Reply-To: <20130903214009.GA16463@kroah.com>
On Tue, Sep 03, 2013 at 02:40:09PM -0700, Greg KH wrote:
> On Tue, Sep 03, 2013 at 05:32:05PM -0400, Dave Jones wrote:
> > PS: What happened with this driver ?
> >
> > This patch landed twice in your tree, once in 1dd3d123239179fad5de5dc00a6e0014a1918fde from Yuan-Hsin Chen <yhchen@faraday-tech.com>
> > and then in 7d50195f6c5005d6ae7a789d9a7f0a94d104ee96 from Feng-Hsin Chiang <john453@faraday-tech.com>
> >
> > Given the former address seems to be broken, perhaps all those mentions of it
> > in the faraday sources need updating ?
>
> I thought they had all been fixed up. The first version was dropped
> because the maintainer no longer worked for the company (as you found
> out), so I needed a new developer to step up and support it.
He's still mentioned in a bunch of MODULE_AUTHOR's.
While it seems sort of rude to delete mention of someones work, having a dead email
address seems bad form too. Perhaps the patch below ?
Dave
Update the MODULE_AUTHOR field of the Faraday OTG drivers to reflect
current maintainers email address.
Signed-off-by: Dave Jones <davej@fedoraproject.org>
diff --git a/drivers/usb/gadget/fotg210-udc.c b/drivers/usb/gadget/fotg210-udc.c
index 32db2ee..bbbfd19 100644
--- a/drivers/usb/gadget/fotg210-udc.c
+++ b/drivers/usb/gadget/fotg210-udc.c
@@ -1214,6 +1214,6 @@ static struct platform_driver fotg210_driver = {
module_platform_driver(fotg210_driver);
-MODULE_AUTHOR("Yuan-Hsin Chen <yhchen@faraday-tech.com>");
+MODULE_AUTHOR("Yuan-Hsin Chen, Feng-Hsin Chiang <john453@faraday-tech.com>");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION(DRIVER_DESC);
diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c
index f1dd6da..b278abe 100644
--- a/drivers/usb/gadget/fusb300_udc.c
+++ b/drivers/usb/gadget/fusb300_udc.c
@@ -22,7 +22,7 @@
MODULE_DESCRIPTION("FUSB300 USB gadget driver");
MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Yuan Hsin Chen <yhchen@faraday-tech.com>");
+MODULE_AUTHOR("Yuan-Hsin Chen, Feng-Hsin Chiang <john453@faraday-tech.com>");
MODULE_ALIAS("platform:fusb300_udc");
#define DRIVER_VERSION "20 October 2010"
next prev parent reply other threads:[~2013-09-03 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130903185912.A59316601F4@gitolite.kernel.org>
2013-09-03 21:15 ` usb: host: Faraday fotg210-hcd driver Dave Jones
2013-09-03 21:23 ` Greg KH
2013-09-03 21:32 ` Dave Jones
2013-09-03 21:40 ` Greg KH
2013-09-03 21:46 ` Dave Jones [this message]
2013-09-03 22:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903214626.GA10542@redhat.com \
--to=davej@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=john453@faraday-tech.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox