From: Bjorn Helgaas <bhelgaas@google.com>
To: Joe Perches <joe@perches.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pci.h: Fix typo, remove unnecessary !!
Date: Tue, 3 Sep 2013 17:10:50 -0600 [thread overview]
Message-ID: <20130903231050.GA24733@google.com> (raw)
In-Reply-To: <1378240265.7347.24.camel@joe-AO722>
On Tue, Sep 03, 2013 at 01:31:05PM -0700, Joe Perches wrote:
> Use normal kernel-doc "Returns:" instead of retruns
> Assignment to bool is always 1 or 0 so the !! isn't necessary.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to pci/misc, thanks. This branch will be rebased and will
not appear in -next until after v3.12-rc1.
> ---
> include/linux/pci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index da172f9..ee0f3b6 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1749,11 +1749,11 @@ static inline int pci_pcie_cap(struct pci_dev *dev)
> * pci_is_pcie - check if the PCI device is PCI Express capable
> * @dev: PCI device
> *
> - * Retrun true if the PCI device is PCI Express capable, false otherwise.
> + * Returns: true if the PCI device is PCI Express capable, false otherwise.
> */
> static inline bool pci_is_pcie(struct pci_dev *dev)
> {
> - return !!pci_pcie_cap(dev);
> + return pci_pcie_cap(dev);
> }
>
> /**
>
>
prev parent reply other threads:[~2013-09-03 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 20:31 [PATCH] pci.h: Fix typo, remove unnecessary !! Joe Perches
2013-09-03 23:10 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903231050.GA24733@google.com \
--to=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox