* [PATCH] pci.h: Fix typo, remove unnecessary !!
@ 2013-09-03 20:31 Joe Perches
2013-09-03 23:10 ` Bjorn Helgaas
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2013-09-03 20:31 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, LKML
Use normal kernel-doc "Returns:" instead of retruns
Assignment to bool is always 1 or 0 so the !! isn't necessary.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/linux/pci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index da172f9..ee0f3b6 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -1749,11 +1749,11 @@ static inline int pci_pcie_cap(struct pci_dev *dev)
* pci_is_pcie - check if the PCI device is PCI Express capable
* @dev: PCI device
*
- * Retrun true if the PCI device is PCI Express capable, false otherwise.
+ * Returns: true if the PCI device is PCI Express capable, false otherwise.
*/
static inline bool pci_is_pcie(struct pci_dev *dev)
{
- return !!pci_pcie_cap(dev);
+ return pci_pcie_cap(dev);
}
/**
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pci.h: Fix typo, remove unnecessary !!
2013-09-03 20:31 [PATCH] pci.h: Fix typo, remove unnecessary !! Joe Perches
@ 2013-09-03 23:10 ` Bjorn Helgaas
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2013-09-03 23:10 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-pci, LKML
On Tue, Sep 03, 2013 at 01:31:05PM -0700, Joe Perches wrote:
> Use normal kernel-doc "Returns:" instead of retruns
> Assignment to bool is always 1 or 0 so the !! isn't necessary.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied to pci/misc, thanks. This branch will be rebased and will
not appear in -next until after v3.12-rc1.
> ---
> include/linux/pci.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index da172f9..ee0f3b6 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1749,11 +1749,11 @@ static inline int pci_pcie_cap(struct pci_dev *dev)
> * pci_is_pcie - check if the PCI device is PCI Express capable
> * @dev: PCI device
> *
> - * Retrun true if the PCI device is PCI Express capable, false otherwise.
> + * Returns: true if the PCI device is PCI Express capable, false otherwise.
> */
> static inline bool pci_is_pcie(struct pci_dev *dev)
> {
> - return !!pci_pcie_cap(dev);
> + return pci_pcie_cap(dev);
> }
>
> /**
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-03 23:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-03 20:31 [PATCH] pci.h: Fix typo, remove unnecessary !! Joe Perches
2013-09-03 23:10 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox