From: Thierry Reding <thierry.reding@gmail.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [GIT PULL] KVM changes for 3.12
Date: Wed, 4 Sep 2013 12:18:28 +0200 [thread overview]
Message-ID: <20130904101826.GA2744@ulmo> (raw)
In-Reply-To: <20130903121046.GE22899@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]
On Tue, Sep 03, 2013 at 03:10:46PM +0300, Gleb Natapov wrote:
[...]
> Aneesh Kumar K.V (5):
> mm/cma: Move dma contiguous changes into a seperate config
Hi Gleb,
This commit is going to cause runtime regressions on various ARM
platforms because it renames a symbol but fails to update all default
configurations that select the symbol. A quick grep shows that three ARM
platforms are affected:
$ git grep CONFIG_CMA=y
arch/arm/configs/keystone_defconfig:CONFIG_CMA=y
arch/arm/configs/omap2plus_defconfig:CONFIG_CMA=y
arch/arm/configs/tegra_defconfig:CONFIG_CMA=y
I've been digging around a bit and it seems like the original patch from
Aneesh had the defconfig changes but they were dropped because they "...
require separate handling to avoid pointless merge conflicts."[0]
While I can't speak for Keystone or OMAP, at least on Tegra this causes
issues because we use CMA for framebuffer allocation. Since we only have
CMA selected but not the new DMA_CMA, large DMA allocations will fail.
Can we have the defconfig changes added back to this patch, please? I
suspect that Linus can handle any resulting merge conflicts.
Thierry
[0]: http://permalink.gmane.org/gmane.linux.kernel.mm/102707
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-04 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 12:10 [GIT PULL] KVM changes for 3.12 Gleb Natapov
2013-09-04 10:18 ` Thierry Reding [this message]
2013-09-04 10:38 ` Gleb Natapov
2013-09-04 18:12 ` Stephen Warren
2013-09-05 1:08 ` Linus Torvalds
2013-09-05 5:53 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904101826.GA2744@ulmo \
--to=thierry.reding@gmail.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox