public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [for-next][PATCH 13/18] ftrace: Disable RCU unsafe checker when function graph is enabled
Date: Wed, 04 Sep 2013 10:36:05 -0400	[thread overview]
Message-ID: <20130904143702.439240564@goodmis.org> (raw)
In-Reply-To: 20130904143552.456506259@goodmis.org

[-- Attachment #1: 0012-ftrace-Disable-RCU-unsafe-checker-when-function-grap.patch --]
[-- Type: text/plain, Size: 1468 bytes --]

From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

Having the RCU unsafe checker running when function graph is enabled
can cause a live lock. That's because the RCU unsafe checker enables
full lockdep debugging on RCU which does a lot of internal calls that
may be traced by the function graph tracer. This adds quite a bit of
overhead and can possibly live lock the system by causing the timer
interrupt to take longer than 1 HZ.

Just do not do the RCU unsafe checks when function graph tracer is
enabled.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ftrace.c |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 9fcf842..899c8c1 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -5118,6 +5118,12 @@ int register_ftrace_graph(trace_func_graph_ret_t retfunc,
 		goto out;
 	}
 
+	/*
+	 * The Unsafe RCU checker can live lock function graph tracing.
+	 * It's best to just disable it while doing the fgraph tracing.
+	 */
+	ftrace_unsafe_rcu_checker_disable();
+
 	ftrace_graph_return = retfunc;
 	ftrace_graph_entry = entryfunc;
 
@@ -5141,6 +5147,7 @@ void unregister_ftrace_graph(void)
 	ftrace_shutdown(&global_ops, FTRACE_STOP_FUNC_RET);
 	unregister_pm_notifier(&ftrace_suspend_notifier);
 	unregister_trace_sched_switch(ftrace_graph_probe_sched_switch, NULL);
+	ftrace_unsafe_rcu_checker_enable();
 
  out:
 	mutex_unlock(&ftrace_lock);
-- 
1.7.10.4



  parent reply	other threads:[~2013-09-04 14:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 14:35 [for-next][PATCH 00/18] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 01/18] tracing: Make tracing_cpumask available for all instances Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 02/18] ftrace: Fix a slight race in modifying what function callback gets traced Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 03/18] ftrace/rcu: Do not trace debug_lockdep_rcu_enabled() Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 04/18] ftrace: Add hash list to save RCU unsafe functions Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 05/18] ftrace: Do not set ftrace records for unsafe RCU when not allowed Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 06/18] ftrace: Set ftrace internal function tracing RCU safe Steven Rostedt
2013-09-04 14:35 ` [for-next][PATCH 07/18] ftrace: Add test for ops against unsafe RCU functions in callback Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 08/18] ftrace: Do not display non safe RCU functions in available_filter_functions Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 09/18] ftrace: Add rcu_unsafe_filter_functions file Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 10/18] ftrace: Add selftest to check if RCU unsafe functions are filtered properly Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 11/18] ftrace: Create a RCU unsafe checker Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 12/18] ftrace: Add infrastructure to stop RCU unsafe checker from checking Steven Rostedt
2013-09-04 14:36 ` Steven Rostedt [this message]
2013-09-04 14:36 ` [for-next][PATCH 14/18] ftrace: Disable the RCU unsafe checker when irqsoff is enabled Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 15/18] ftrace/lockdep: Have the RCU lockdep splat show what function triggered Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 16/18] ftrace/rcu: Mark functions that are RCU unsafe Steven Rostedt
2013-09-04 16:43   ` Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 17/18] ftrace/cpuidle/x86: " Steven Rostedt
2013-09-04 14:36 ` [for-next][PATCH 18/18] ftrace: Print a message when the rcu checker is disabled Steven Rostedt
2013-09-04 18:27 ` [for-next][PATCH 00/18] ftrace/rcu: Handle unsafe RCU functions and ftrace callbacks Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904143702.439240564@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox