linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Wu <lekensteyn@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] writeback: fix NULL dereference when device is gone
Date: Wed, 4 Sep 2013 14:21:17 -0400	[thread overview]
Message-ID: <20130904182117.GE26609@mtj.dyndns.org> (raw)
In-Reply-To: <2884335.eGSKV8oXr1@al>

Hello,

On Thu, Aug 29, 2013 at 12:31:11AM +0200, Peter Wu wrote:
> I applied your fix in the workfn, but now dd does not stop with EIO. If I run 
> `sync`, then I see:
> 
> [11882.645618] quiet_error: 591905 callbacks suppressed
> [11882.650589] Buffer I/O error on device sdd, logical block 129652880
> [11882.656850] lost page write due to I/O error on sdd
> [11882.661974] Buffer I/O error on device sdd, logical block 129652881
> ...
> 
> Any other ideas? For now I will stick to the original patch. That probably 
> does not solve the root issues, but it is at least a workaround to prevent the 
> machine from locking up.

I'm out of ideas at the moment and maybe we should just stick to your
patch for now.  :(

Thanks.

-- 
tejun

      reply	other threads:[~2013-09-04 18:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-18  1:08 [3.11-rc5..] NULL pointer dereference in bdi_writeback_workfn Alan Stern
2013-08-19 22:45 ` [PATCH] writeback: fix NULL dereference when device is gone Peter Wu
2013-08-19 23:02   ` Tejun Heo
2013-08-20 10:13     ` Peter Wu
2013-08-20 13:33       ` Tejun Heo
2013-08-28 22:31         ` Peter Wu
2013-09-04 18:21           ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904182117.GE26609@mtj.dyndns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=lekensteyn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).