From: Kent Overstreet <kmo@daterainc.com>
To: kernel neophyte <neophyte.hacker001@gmail.com>
Cc: "linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefan Priebe <s.priebe@profihost.ag>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] bcache: Fix a shrinker deadlock
Date: Wed, 4 Sep 2013 16:45:04 -0700 [thread overview]
Message-ID: <20130904234504.GA2635@kmo-pixel> (raw)
In-Reply-To: <CAFkUHxfYeF8G+r3RYp3dTaOBzPqo_diVoF5g_7sAeW+wKprrjA@mail.gmail.com>
On Wed, Sep 04, 2013 at 04:35:50PM -0700, kernel neophyte wrote:
> On Fri, Aug 30, 2013 at 2:15 PM, Kent Overstreet <kmo@daterainc.com> wrote:
> > GFP_NOIO means we could be getting called recursively - mca_alloc() ->
> > mca_data_alloc() - definitely can't use mutex_lock(bucket_lock) then.
> > Whoops.
> >
> > Signed-off-by: Kent Overstreet <kmo@daterainc.com>
>
> Awesome! I tested the fix... no crashes/deadlock.
> But I see lower benchmark numbers for random write.. is this expected
> for this change ?
No... how much lower?
prev parent reply other threads:[~2013-09-04 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 0:29 Bcache sleeps forever on random writes kernel neophyte
2013-08-30 1:16 ` kernel neophyte
2013-08-30 21:15 ` [PATCH] bcache: Fix a shrinker deadlock Kent Overstreet
2013-08-31 4:20 ` Jens Axboe
2013-08-31 13:37 ` Stefan Priebe
2013-09-03 20:51 ` Stefan Priebe - Profihost AG
2013-09-04 23:35 ` kernel neophyte
2013-09-04 23:45 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904234504.GA2635@kmo-pixel \
--to=kmo@daterainc.com \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neophyte.hacker001@gmail.com \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox