From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Aravind.Gopalakrishnan@amd.com
Subject: Re: amd64_edac: Add ECC decoding support for newer F15h models
Date: Thu, 5 Sep 2013 10:43:53 -0400 [thread overview]
Message-ID: <20130905144353.GB15894@redhat.com> (raw)
In-Reply-To: <20130904185224.67DFF660948@gitolite.kernel.org>
On Wed, Sep 04, 2013 at 06:52:24PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=18b94f66f9537003cee30d475d79a57c58f1e1d8
> Commit: 18b94f66f9537003cee30d475d79a57c58f1e1d8
> Parent: 7d64ac6422092adbbdaa279ab32f9d4c90a84558
> Author: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> AuthorDate: Fri Aug 9 11:54:49 2013 -0500
> Committer: Borislav Petkov <bp@suse.de>
> CommitDate: Mon Aug 12 16:00:10 2013 +0200
>
> amd64_edac: Add ECC decoding support for newer F15h models
> +static int f15_m30h_match_to_this_node(struct amd64_pvt *pvt, unsigned range,
> + u64 sys_addr, int *chan_sel)
> +{
> + ...
> + u8 channel, alias_channel, leg_mmio_hole, dct_sel, dct_offset_en;
^^^^^^^^^^
> +
> + ....
> +
> + channel = f15_m30h_determine_channel(pvt, sys_addr, intlv_en,
> + num_dcts_intlv, dct_sel);
> +
> + /* Verify we stay within the MAX number of channels allowed */
> + if (channel > 4 || channel < 0)
> + return -EINVAL;
Channel will never be < 0, as it's unsigned.
Dave
next parent reply other threads:[~2013-09-05 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130904185224.67DFF660948@gitolite.kernel.org>
2013-09-05 14:43 ` Dave Jones [this message]
2013-09-11 14:44 ` amd64_edac: Add ECC decoding support for newer F15h models Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905144353.GB15894@redhat.com \
--to=davej@redhat.com \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox