public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Avi <avi.kp.137@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)
Date: Thu, 5 Sep 2013 19:32:16 +0300	[thread overview]
Message-ID: <20130905163216.GO6329@mwanda> (raw)
In-Reply-To: <20130905155154.GA7535@avi-VPCCW15FG>

Please send this instead of as an attachment.  Send it to yourself first
and apply it with 'git am'.  Resend when that works.

> From: AVI <avi@avi-VPCCW15FG.(none)>
                 ^^^^^^^^^^^^^^^^^^^^
That's wrong.

The subject is too long and not the right format.  It should be:

Subject: [PATCH] Staging: bcm: white space complaint with casting

Put the exact complaint in the body of the email.

Add a blank line before the Signed-off-by line.

regards,
dan carpenter





  parent reply	other threads:[~2013-09-05 16:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 15:51 drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *) Avi
2013-09-05 16:01 ` Greg Kroah-Hartman
2013-09-05 16:32 ` Dan Carpenter [this message]
2013-09-05 16:36   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905163216.GO6329@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=avi.kp.137@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox