drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)

drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)

[Avi]

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-drivers-staging-bcm-InterfaceMisc.c-107-ERROR-foo-sh.patch --]
[-- Type: text/x-diff, Size: 860 bytes --]

>From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
From: AVI <avi@avi-VPCCW15FG.(none)>
Date: Thu, 5 Sep 2013 21:03:45 +0530
Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)"
 should be "(foo *)" 
Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

---
 drivers/staging/bcm/InterfaceMisc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
index afca010..d9fa2bb 100644
--- a/drivers/staging/bcm/InterfaceMisc.c
+++ b/drivers/staging/bcm/InterfaceMisc.c
@@ -104,7 +104,7 @@ int BcmRDM(void *arg,
 	void *buff,
 	int len)
 {
-	return InterfaceRDM((struct bcm_interface_adapter*)arg, addr, buff, len);
+	return InterfaceRDM((struct bcm_interface_adapter *)arg, addr, buff, len);
 }
 
 int BcmWRM(void *arg,
-- 
1.7.10.4

Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)

[Greg Kroah-Hartman]

On Thu, Sep 05, 2013 at 09:21:54PM +0530, Avi wrote:

> >From 91e1d42ce8b52cc28689ea4e56c71b790217cf91 Mon Sep 17 00:00:00 2001
> From: AVI <avi@avi-VPCCW15FG.(none)>

Why have you attached your patch?  And this "From:" line is obviously
wrong :(

> Date: Thu, 5 Sep 2013 21:03:45 +0530
> Subject: [PATCH] drivers/staging/bcm/InterfaceMisc.c:107: ERROR: "(foo*)"
>  should be "(foo *)" 
> Signed-off-by: Avinash Kumar <avi.kp.137@gmail.com>

You need to put some type of description in the changelog section.

And a new line before the signed-off-by: line.

Can you just use git send-email to send the patch, and not attach it, so
that I don't have to hand-edit the patch in order to apply it properly?

thanks,

greg k-h

Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)

[Dan Carpenter]

Please send this instead of as an attachment.  Send it to yourself first
and apply it with 'git am'.  Resend when that works.

> From: AVI <avi@avi-VPCCW15FG.(none)>
                 ^^^^^^^^^^^^^^^^^^^^
That's wrong.

The subject is too long and not the right format.  It should be:

Subject: [PATCH] Staging: bcm: white space complaint with casting

Put the exact complaint in the body of the email.

Add a blank line before the Signed-off-by line.

regards,
dan carpenter

Re: drivers/staging/bcm/InterfaceMisc.c-checkpatch cleanup-(foo*)->(foo *)

[Dan Carpenter]

On Thu, Sep 05, 2013 at 07:32:16PM +0300, Dan Carpenter wrote:
> Please send this instead of as an attachment.

Send this *inline* I meant.

regards,
dan carpenter