public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random, Add user configurable get_bytes_random()
Date: Thu, 5 Sep 2013 15:03:34 -0400	[thread overview]
Message-ID: <20130905190334.GC23661@thunk.org> (raw)
In-Reply-To: <52289E6C.8090301@redhat.com>

On Thu, Sep 05, 2013 at 11:08:28AM -0400, Prarit Bhargava wrote:
> 
> The issue isn't userspace /dev/random as much as it is the use of
> get_random_bytes() through out the kernel.  Switching to get_random_bytes_arch()
> is a search'n'replace on the entire kernel.  If a user wants the faster random
> HW generator why shouldn't they be able to use it by default?

Where is the speed of the random number generator a bottleneck?

In general, adding knobs when users can make what might be potentially
the wrong chance is very dangerous.  There is a reason why there
aren't convenient knobs to allow users to select the use of the MD4
checksum, "because it might be faster, why shouldn't the user be
allowed to shoot themselves in the foot"?

					- Ted

  reply	other threads:[~2013-09-05 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 12:18 [PATCH] random, Add user configurable get_bytes_random() Prarit Bhargava
2013-09-05 14:48 ` Theodore Ts'o
2013-09-05 15:08   ` Prarit Bhargava
2013-09-05 19:03     ` Theodore Ts'o [this message]
2013-09-05 19:49       ` Theodore Ts'o
2013-09-06 12:08         ` Prarit Bhargava
2013-09-06 13:57           ` Theodore Ts'o
2013-09-12 17:40             ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130905190334.GC23661@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox