public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf: builtin-trace.c: check if MAP_32BIT is defined
@ 2013-09-05 14:29 Kyle McMartin
  2013-09-05 19:25 ` Arnaldo Carvalho de Melo
  2013-09-06 12:14 ` [tip:perf/urgent] perf trace: Check " tip-bot for Kyle McMartin
  0 siblings, 2 replies; 3+ messages in thread
From: Kyle McMartin @ 2013-09-05 14:29 UTC (permalink / raw)
  To: torvalds; +Cc: mingo, acme, linux-kernel

From: Kyle McMartin <kyle@redhat.com>

MAP_32BIT is defined only on x86... this means perf fails to build on
all other platforms.

Signed-off-by: Kyle McMartin <kyle@redhat.com>

--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -100,7 +100,9 @@ static size_t syscall_arg__scnprintf_mmap_flags(char *bf, size_t size,
 
 	P_MMAP_FLAG(SHARED);
 	P_MMAP_FLAG(PRIVATE);
+#ifdef MAP_32BIT
 	P_MMAP_FLAG(32BIT);
+#endif
 	P_MMAP_FLAG(ANONYMOUS);
 	P_MMAP_FLAG(DENYWRITE);
 	P_MMAP_FLAG(EXECUTABLE);

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf: builtin-trace.c: check if MAP_32BIT is defined
  2013-09-05 14:29 [PATCH] perf: builtin-trace.c: check if MAP_32BIT is defined Kyle McMartin
@ 2013-09-05 19:25 ` Arnaldo Carvalho de Melo
  2013-09-06 12:14 ` [tip:perf/urgent] perf trace: Check " tip-bot for Kyle McMartin
  1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2013-09-05 19:25 UTC (permalink / raw)
  To: Kyle McMartin; +Cc: torvalds, mingo, linux-kernel

Em Thu, Sep 05, 2013 at 10:29:47AM -0400, Kyle McMartin escreveu:
> From: Kyle McMartin <kyle@redhat.com>
> 
> MAP_32BIT is defined only on x86... this means perf fails to build on
> all other platforms.
> 
> Signed-off-by: Kyle McMartin <kyle@redhat.com>

Thanks, applying.

- Arnaldo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:perf/urgent] perf trace: Check if MAP_32BIT is defined
  2013-09-05 14:29 [PATCH] perf: builtin-trace.c: check if MAP_32BIT is defined Kyle McMartin
  2013-09-05 19:25 ` Arnaldo Carvalho de Melo
@ 2013-09-06 12:14 ` tip-bot for Kyle McMartin
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Kyle McMartin @ 2013-09-06 12:14 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, linux-kernel, mingo, hpa, mingo, torvalds, kyle, tglx

Commit-ID:  41817815666e4a6f302dad1fea47cbe64cc45e40
Gitweb:     http://git.kernel.org/tip/41817815666e4a6f302dad1fea47cbe64cc45e40
Author:     Kyle McMartin <kyle@redhat.com>
AuthorDate: Thu, 5 Sep 2013 10:29:47 -0400
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 5 Sep 2013 16:18:46 -0300

perf trace: Check if MAP_32BIT is defined

MAP_32BIT is defined only on x86... this means perf fails to build on
all other platforms.

Signed-off-by: Kyle McMartin <kyle@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20130905142947.GA25882@merlin.infradead.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-trace.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 6016112..f5aa637 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -100,7 +100,9 @@ static size_t syscall_arg__scnprintf_mmap_flags(char *bf, size_t size,
 
 	P_MMAP_FLAG(SHARED);
 	P_MMAP_FLAG(PRIVATE);
+#ifdef MAP_32BIT
 	P_MMAP_FLAG(32BIT);
+#endif
 	P_MMAP_FLAG(ANONYMOUS);
 	P_MMAP_FLAG(DENYWRITE);
 	P_MMAP_FLAG(EXECUTABLE);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-09-06 12:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 14:29 [PATCH] perf: builtin-trace.c: check if MAP_32BIT is defined Kyle McMartin
2013-09-05 19:25 ` Arnaldo Carvalho de Melo
2013-09-06 12:14 ` [tip:perf/urgent] perf trace: Check " tip-bot for Kyle McMartin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox