public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: ftrace 'failed to modify' bug when loading reiserfs.ko
Date: Thu, 5 Sep 2013 23:58:27 -0400	[thread overview]
Message-ID: <20130906035827.GA13446@redhat.com> (raw)
In-Reply-To: <20130905215154.74c55e9a@gandalf.local.home>

On Thu, Sep 05, 2013 at 09:51:54PM -0400, Steven Rostedt wrote:
 > On Thu, 5 Sep 2013 21:48:59 -0400
 > Dave Jones <davej@redhat.com> wrote:
 > 
 > > On Thu, Sep 05, 2013 at 09:44:55PM -0400, Steven Rostedt wrote:
 > >  > On Thu, 5 Sep 2013 21:34:55 -0400
 > >  > Dave Jones <davej@redhat.com> wrote:
 > >  > 
 > >  > > On Thu, Sep 05, 2013 at 09:28:34PM -0400, Steven Rostedt wrote:
 > 
 > >  > Did you change a config option, or update your gcc?
 > > 
 > > Yeah, changed CONFIG_DEBUG_KOBJECT, which rebuilt the world.
 > 
 > Still doesn't explain why it gave you that splat there.
 > 
 > Do you still have that binary module, and can you show me what's at
 > reiserfs_init_bitmap_cache+0x0 with objdump?

I didn't, but it turns out I can recreate this. A little convoluted but..

disable DEBUG_KOBJECT_RELEASE
build, install and boot into kernel

enable DEBUG_KOBJECT_RELEASE
build kernel
install -> boom


00000000000028b0 <reiserfs_init_bitmap_cache>:

        return bh;
}

int reiserfs_init_bitmap_cache(struct super_block *sb)
{
    28b0:       e8 00 00 00 00          callq  28b5 <reiserfs_init_bitmap_cache+0x5>
    28b5:       55                      push   %rbp

/* Don't trust REISERFS_SB(sb)->s_bmap_nr, it's a u16
 * which overflows on large file systems. */
static inline __u32 reiserfs_bmap_count(struct super_block *sb)
{
        return (SB_BLOCK_COUNT(sb) - 1) / (sb->s_blocksize * 8) + 1;
    28b6:       31 d2                   xor    %edx,%edx
    28b8:       48 89 e5                mov    %rsp,%rbp
    28bb:       41 54                   push   %r12
    28bd:       53                      push   %rbx
    28be:       48 89 fb                mov    %rdi,%rbx
    28c1:       48 8b 87 50 07 00 00    mov    0x750(%rdi),%rax
    28c8:       48 8b 77 18             mov    0x18(%rdi),%rsi
    28cc:       48 8b 40 08             mov    0x8(%rax),%rax
    28d0:       48 8d 0c f5 00 00 00    lea    0x0(,%rsi,8),%rcx
    28d7:       00 
    28d8:       8b 00                   mov    (%rax),%eax
    28da:       83 e8 01                sub    $0x1,%eax
    28dd:       48 f7 f1                div    %rcx


  reply	other threads:[~2013-09-06  3:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06  1:19 ftrace 'failed to modify' bug when loading reiserfs.ko Dave Jones
2013-09-06  1:28 ` Steven Rostedt
2013-09-06  1:34   ` Dave Jones
2013-09-06  1:44     ` Steven Rostedt
2013-09-06  1:48       ` Dave Jones
2013-09-06  1:51         ` Steven Rostedt
2013-09-06  3:58           ` Dave Jones [this message]
2013-09-06 13:32             ` Steven Rostedt
2013-09-06 14:18               ` Dave Jones
2013-09-06 14:24                 ` Steven Rostedt
2013-09-06 14:41                   ` Kyle McMartin
2013-09-06 15:22                     ` Dave Jones
2013-09-06 15:34                       ` Steven Rostedt
2013-09-06 15:46                         ` Josh Boyer
2013-09-06 16:07                           ` Steven Rostedt
2013-09-06 16:12                             ` Josh Boyer
2013-09-06 16:40                               ` richard -rw- weinberger
2013-09-06 17:50                                 ` Josh Boyer
2013-09-06 16:44                               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130906035827.GA13446@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox