From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Rusty Russell <rusty@rustcorp.com.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
Rob Landley <rob@landley.net>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-doc@vger.kernel.org, Asias He <asias@redhat.com>,
Nikhil Rao <nikhil.rao@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Caz Yokoyama <Caz.Yokoyama@intel.com>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli@intel.com>,
Harshavardhan R Kharche <harshavardhan.r.kharche@intel.com>,
"Yaozu (Eddie) Dong" <eddie.dong@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family.
Date: Thu, 5 Sep 2013 21:57:22 -0700 [thread overview]
Message-ID: <20130906045722.GC28806@kroah.com> (raw)
In-Reply-To: <8b972a444f4529ecffc718db4112aa8959bf72ad.1378423596.git.sudeep.dutt@intel.com>
On Thu, Sep 05, 2013 at 04:41:31PM -0700, Sudeep Dutt wrote:
> drivers/misc/mic/common/mic_device.h | 37 +++
> drivers/misc/mic/host/mic_device.h | 109 +++++++++
Two different files, with the same name? You are asking for trouble in
the future, getting them confused :)
Please try to pick a unique name, especially when you later do things
like:
> +#include "../common/mic_device.h"
> +#include "mic_device.h"
Which just looks odd.
Again, not a big deal, follow-on patch can fix this.
thanks,
greg k-h
next prev parent reply other threads:[~2013-09-06 4:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 23:41 [PATCH RESEND v3 0/7] Enable Drivers for Intel MIC X100 Coprocessors Sudeep Dutt
2013-09-05 23:41 ` [PATCH RESEND v3 1/7] Intel MIC Host Driver for X100 family Sudeep Dutt
2013-09-06 4:55 ` Greg Kroah-Hartman
2013-09-06 4:57 ` Greg Kroah-Hartman [this message]
2013-09-05 23:41 ` [PATCH RESEND v3 2/7] Intel MIC Host Driver Interrupt/SMPT support Sudeep Dutt
2013-09-05 23:41 ` [PATCH RESEND v3 3/7] Intel MIC Host Driver, card OS state management Sudeep Dutt
2013-09-06 4:58 ` Greg Kroah-Hartman
2013-09-06 18:29 ` Sudeep Dutt
2013-09-06 18:41 ` Greg Kroah-Hartman
2013-09-06 5:00 ` Greg Kroah-Hartman
2013-09-06 18:30 ` Sudeep Dutt
2013-09-06 5:01 ` Greg Kroah-Hartman
2013-09-06 18:41 ` Sudeep Dutt
2013-09-06 19:04 ` Greg Kroah-Hartman
2013-09-06 22:00 ` Sudeep Dutt
2013-09-05 23:42 ` [PATCH RESEND v3 4/7] Intel MIC Card Driver for X100 family Sudeep Dutt
2013-09-05 23:42 ` [PATCH RESEND v3 5/7] Intel MIC Host Driver Changes for Virtio Devices Sudeep Dutt
2013-09-05 23:42 ` [PATCH RESEND v3 6/7] Intel MIC Card " Sudeep Dutt
2013-09-05 23:42 ` [PATCH RESEND v3 7/7] Sample Implementation of Intel MIC User Space Daemon Sudeep Dutt
2013-09-06 1:36 ` [PATCH RESEND v3 0/7] Enable Drivers for Intel MIC X100 Coprocessors Joe Perches
2013-09-06 18:27 ` Sudeep Dutt
2013-09-26 20:54 ` Greg Kroah-Hartman
2013-09-26 21:33 ` Joe Perches
2013-09-26 21:40 ` Sudeep Dutt
2013-09-26 20:53 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906045722.GC28806@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Caz.Yokoyama@intel.com \
--cc=arnd@arndb.de \
--cc=ashutosh.dixit@intel.com \
--cc=asias@redhat.com \
--cc=dasaratharaman.chandramouli@intel.com \
--cc=eddie.dong@intel.com \
--cc=harshavardhan.r.kharche@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nikhil.rao@intel.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rob@landley.net \
--cc=rusty@rustcorp.com.au \
--cc=sudeep.dutt@intel.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox