Re: [PATCH] ADP1653 board code for Nokia RX-51

Pavel Machek
2013-03-30T18:24:50Z

Hi!

> +static int __init rx51_camera_hw_init(void)
> +{
> + int rval;
> +
> + rval = rx51_adp1653_init();
> + if (rval)
> + return rval;
> +
> + return 0;
> +}

"return rx51_adp1653_init()". Or better yet, rename rx51_adp1653_init
to rx51_camera_hw_init.

Thanks for all the n900 work, btw :-).

> +static struct adp1653_platform_data rx51_adp1653_platform_data = {
> + .power = rx51_adp1653_power,
> + /* Must be limited to 500 ms in RX-51 */
> + .max_flash_timeout = 500000, /* us */
> + /* Must be limited to 320 mA in RX-51 B3 and newer hardware */
> + .max_flash_intensity = ADP1653_FLASH_INTENSITY_REG_TO_mA(19),
> + /* Must be limited to 50 mA in RX-51 */
> + .max_torch_intensity = > ADP1653_FLASH_INTENSITY_REG_TO_mA(1),

So we do 1mA to be safe?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html