Re: [PATCH] x86, build: move build output statistics away from stderr

[Ingo Molnar <mingo@kernel.org>]

* Kees Cook <keescook@chromium.org> wrote:

> When building on x86, the final image building step always emits stats
> to stderr, even though this information is neither a warning nor an error:
> 
>   BUILD   arch/x86/boot/bzImage
> Setup is 16188 bytes (padded to 16384 bytes).
> System is 6368 kB
> CRC cbe50c61
> 
> Validating automated builds would be cleaner if stderr did not have to 
> filter out these lines. Instead, change how tools/build is called, and 
> make the zoffset header unconditional, and write to a specified file 
> instead of to stdout, which can then be used for statistics, leaving 
> stderr open for legitimate warnings and errors, like the output from 
> die().

Nice, that output to stderr was always somewhat annoying.

> +	/* Catch any delayed write failures */
> +	if (fclose(dest))
> +		die("Writing image failed");
> +
>  	close(fd);

Looks like the new code is not just reporting errors better, but it's more 
robust by catching and reporting fclose()-time failures as well, avoiding 
a corrupt kernel image in certain corner cases - the most common being a 
file system full error I suspect.

Thanks,

	Ingo