* [PATCH] mfd: sm501: dbg_regs attribute must be read-only
@ 2013-09-08 7:25 Guenter Roeck
2013-09-09 9:03 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2013-09-08 7:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Lee Jones, Guenter Roeck
Fix:
sm501 sm501: SM501 At b3e00000: Version 050100a0, 8 Mb, IRQ 100
Attribute dbg_regs: write permission without 'store'
------------[ cut here ]------------
WARNING: at drivers/base/core.c:620
dbg_regs does not have a write function and must therefore be marked
as read-only.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/mfd/sm501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
index 33f040c..3799a3d 100644
--- a/drivers/mfd/sm501.c
+++ b/drivers/mfd/sm501.c
@@ -1232,7 +1232,7 @@ static ssize_t sm501_dbg_regs(struct device *dev,
}
-static DEVICE_ATTR(dbg_regs, 0666, sm501_dbg_regs, NULL);
+static DEVICE_ATTR(dbg_regs, 0444, sm501_dbg_regs, NULL);
/* sm501_init_reg
*
--
1.7.9.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: sm501: dbg_regs attribute must be read-only
2013-09-08 7:25 [PATCH] mfd: sm501: dbg_regs attribute must be read-only Guenter Roeck
@ 2013-09-09 9:03 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-09-09 9:03 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-kernel, Samuel Ortiz
On Sun, 08 Sep 2013, Guenter Roeck wrote:
> Fix:
>
> sm501 sm501: SM501 At b3e00000: Version 050100a0, 8 Mb, IRQ 100
> Attribute dbg_regs: write permission without 'store'
> ------------[ cut here ]------------
> WARNING: at drivers/base/core.c:620
>
> dbg_regs does not have a write function and must therefore be marked
> as read-only.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/mfd/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-09 9:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-08 7:25 [PATCH] mfd: sm501: dbg_regs attribute must be read-only Guenter Roeck
2013-09-09 9:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox