From: Lee Jones <lee.jones@linaro.org>
To: wwang <wei_wang@realsil.com.cn>
Cc: sameo@linux.intel.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
rogerable@realtek.com, micky_ching@realsil.com.cn
Subject: Re: [PATCH v2] mfd: rtsx: Modify rts5249_optimize_phy
Date: Tue, 10 Sep 2013 08:29:25 +0100 [thread overview]
Message-ID: <20130910072925.GA1456@lee--X1> (raw)
In-Reply-To: <522E7154.7060706@realsil.com.cn>
On Tue, 10 Sep 2013, wwang wrote:
> 于 2013年09月09日 21:02, Lee Jones 写道:
> >> #define PHY_FLD4 0x1E
> >>>+#define FLDEN_SEL 0x4000
> >>>+#define REQ_REF 0x2000
> >>>+#define RXAMP_OFF 0x1000
> >>>+#define REQ_ADDA 0x0800
> >>>+#define BER_COUNT 0x00E0
> >>>+#define BER_TIMER 0x000A
> >>>+#define BER_CHK_EN 0x0001
> >>> #define PHY_DUM_REG 0x1F
> >>> > #define LCTLR 0x80
> >This doesn't look right.
> >
> >We had a nicely structured, ordered list and now you've seemingly
> >randomly shoved a truck load of un-prefixed defines between them.
> >
> >Am I missing something? Is there method to the madness?
>
> Are you suggesting that I should define the macros using the same
> prefix like below?
>
> #define PHY_FLD4 0x1E
> #define FLD4_FLDEN_SEL 0x4000
> #define FLD4_REQ_REF 0x2000
> #define FLD4_RXAMP_OFF 0x1000
Ah good, so there was at least some kind of method there. :)
Yes I am, but make them seperate, so perhaps:
/* Phy registers */
#define PHY_PCR 0x00
#define PHY_RCR0 0x01
#define PHY_RCR1 0x02
#define PHY_RCR2 0x03
<snip>
+/* Phy bits */
+#define PHY_PCR_FORCE_CODE 0xB000
+#define PHY_PCR_OOBS_CALI_50 0x0800
+#define PHY_PCR_OOBS_VCM_08 0x0200
+#define PHY_PCR_OOBS_SEN_90 0x0040
+#define PHY_PCR_RSSI_EN 0x0002
+#define PHY_RCR1_ADP_TIME 0x0100
+#define PHY_RCR1_VCO_COARSE 0x001F
+#define PHY_RCR2_EMPHASE_EN 0x8000
+#define PHY_RCR2_NADJR 0x4000
+#define PHY_RCR2_CDR_CP_10 0x0400
+#define PHY_RCR2_CDR_SR_2 0x0100
+#define PHY_RCR2_FREQSEL_12 0x0040
+#define PHY_RCR2_CPADJEN 0x0020
+#define PHY_RCR2_CDR_SC_8 0x0008
+#define PHY_RCR2_CALIB_LATE 0x0002
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-10 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 3:40 [PATCH v2] mfd: rtsx: Modify rts5249_optimize_phy wei_wang
2013-09-06 3:40 ` wei_wang
2013-09-09 13:02 ` Lee Jones
2013-09-10 1:09 ` wwang
2013-09-10 7:29 ` Lee Jones [this message]
2013-09-09 13:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910072925.GA1456@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox