From: Ingo Molnar <mingo@kernel.org>
To: "Jiri Olsa" <jolsa@redhat.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/3] perf callchain: Convert children list to rbtree
Date: Tue, 10 Sep 2013 12:25:54 +0200 [thread overview]
Message-ID: <20130910102554.GA5087@gmail.com> (raw)
In-Reply-To: <20130910095216.GB18115@krava.redhat.com>
* Jiri Olsa <jolsa@redhat.com> wrote:
> On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > Current collapse stage has a scalability problem which can be
> > reproduced easily with parallel kernel build. This is because it
> > needs to traverse every children of callchain linearly during the
> > collapse/merge stage. Convert it to rbtree reduced the overhead
> > significantly.
> >
> > On my 400MB perf.data file which recorded with make -j32 kernel build:
>
>
> nice!!!
Nice indeed!
> tried on 2.6 GB data file from kernel make -j64 and got report speed up
> from 'never' to 2m52.756s ;-)
It's still rather long though, unacceptable for everyday usage :-/
Frederic thought that we could reduce minimize collapsing to begin with.
Frederic, could you outline that in more detail please?
Thanks,
Ingo
next prev parent reply other threads:[~2013-09-10 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 8:24 [PATCH 0/3] perf tools: Fix scalability problem on callchain merging Namhyung Kim
2013-09-10 8:24 ` [PATCH 1/3] perf callchain: Convert children list to rbtree Namhyung Kim
2013-09-10 9:02 ` Namhyung Kim
2013-09-10 9:52 ` Jiri Olsa
2013-09-10 10:25 ` Ingo Molnar [this message]
2013-09-10 11:34 ` Frederic Weisbecker
2013-09-22 11:15 ` Jiri Olsa
2013-09-23 9:29 ` Namhyung Kim
2013-09-23 9:36 ` Jiri Olsa
2013-09-10 8:24 ` [PATCH 2/3] perf ui/progress: Add new helper functions for progress bar Namhyung Kim
2013-09-10 8:24 ` [PATCH 3/3] perf tools: Show progress on histogram collapsing Namhyung Kim
2013-09-10 11:58 ` [PATCH 0/3] perf tools: Fix scalability problem on callchain merging Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910102554.GA5087@gmail.com \
--to=mingo@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox