From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
Jin Park <jinyoungp@nvidia.com>
Subject: Re: [PATCH 1/1] mfd: aat2870: Fix sparse error
Date: Tue, 10 Sep 2013 12:20:14 +0100 [thread overview]
Message-ID: <20130910112014.GE1456@lee--X1> (raw)
In-Reply-To: <1378810550-5450-1-git-send-email-sachin.kamat@linaro.org>
On Tue, 10 Sep 2013, Sachin Kamat wrote:
> Fixes the following error:
> drivers/mfd/aat2870-core.c:296:20: error:
> incompatible types in comparison expression (different type sizes)
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Jin Park <jinyoungp@nvidia.com>
> ---
> drivers/mfd/aat2870-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/aat2870-core.c b/drivers/mfd/aat2870-core.c
> index 6f68472..14d9542 100644
> --- a/drivers/mfd/aat2870-core.c
> +++ b/drivers/mfd/aat2870-core.c
> @@ -293,7 +293,7 @@ static ssize_t aat2870_reg_write_file(struct file *file,
> unsigned long addr, val;
> int ret;
>
> - buf_size = min(count, (sizeof(buf)-1));
> + buf_size = min(count, (size_t)(sizeof(buf)-1));
> if (copy_from_user(buf, user_buf, buf_size)) {
> dev_err(aat2870->dev, "Failed to copy from user\n");
> return -EFAULT;
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-09-10 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 10:55 [PATCH 1/1] mfd: aat2870: Fix sparse error Sachin Kamat
2013-09-10 11:20 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910112014.GE1456@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jinyoungp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox