Re: [RFC PATCH] timekeeping: introduce timekeeping_is_busy()

Peter Zijlstra
2013-09-12T14:47:19Z

On Thu, Sep 12, 2013 at 09:48:16AM -0400, Mathieu Desnoyers wrote:

> struct foo {
> ...
> };
>
> spinlock_t foo_lock;
>
> struct latchfoo {
> unsigned int head, tail;
> struct foo data[2];
> };
>
> /**
> * foo_write_begin - begin foo update.
> *
> " @lf: struct latchfoo to update.
> * @prev: pointer to previous element (output parameter).
> * @next: pointer to next element (output parameter).
> *
> * The area pointed to by "next" should be considered uninitialized.
> * The caller needs to have exclusive update access to struct latchfoo.
> */
> static
> void foo_write_begin(struct latchfoo *lf, const struct foo **prev,
> struct foo **next)
> {
> lf->head++;
> smp_wmb();
> *prev = &lf->data[lf->tail & 1];
> *next = &lf->data[lf->head & 1];
> }
>
> /**
> * foo_write_end - end foo update.
> *
> " @lf: struct latchfoo.
> *
> * The caller needs to have exclusive update access to struct latchfoo.
> */
> static void
> void foo_write_end(struct latchfoo *lf)
> {
> smp_wmb();
> lf->tail++;
> }
>
> /**
> * foo_read_begin - begin foo read.
> *
> " @lf: struct latchfoo to read.
> * @tail: pointer to unsigned int containing tail position (output).
> */
> static
> struct foo *foo_read_begin(struct latchfoo *lf, unsigned int *tail)
> {
> unsigned int ret;
>
> ret = ACCESS_ONCE(lf->tail);
> smp_rmb();
> *tail = ret;
> return &lf->data[ret & 1];
> }
>
> /**
> * foo_read_retry - end foo read, trigger retry if needed.
> *
> " @lf: struct latchfoo read.
> * @tail: tail position returned as output by foo_read_begin().
> *
> * If foo_read_retry() returns nonzero, the content of the read should
> * be considered invalid, and the read should be performed again to
> * reattempt reading coherent data, starting with foo_read_begin().
> */
> static
> int foo_read_retry(struct latchfoo *lf, unsigned int tail)
> {
> smp_rmb();
> return (ACCESS_ONCE(lf->head) - tail >= 2);
> }

Yep, that's good. I suppose if there's multiple use sites we can jump
through another few hoops to get rid of the specific struct foo
assumptions by storing sizeof() whatever we do use and playing pointer
math games.

But for now with the time stuff as only user this looks ok.