Re: [RFC PATCH] timekeeping: introduce timekeeping_is_busy()

Peter Zijlstra
2013-09-12T12:09:40Z

On Wed, Sep 11, 2013 at 11:22:52PM -0400, Mathieu Desnoyers wrote:
> Cool!
>
> Your design looks good to me. It reminds me of a latch. My only fear is
> that struct timekeeper is probably too large to be copied every time on
> the read path. Here is a slightly reworked version that would allow
> in-place read of "foo" without copy.
>
> struct foo {
> ...
> };
>
> struct latchfoo {
> unsigned int head, tail;
> spinlock_t write_lock;
> struct foo data[2];
> };
>
> static
> void foo_update(struct latchfoo *lf, void cb(struct foo *foo), void *ctx)
> {
> spin_lock(&lf->write_lock);
> lf->head++;
> smp_wmb();
> lf->data[lf->head & 1] = lf->data[lf->tail & 1];
> cb(&lf->data[lf->head & 1], ctx);

You do that initial copy such that the cb gets the previous state to
work from and doesn't have to do a fetch/complete rewrite?

The alternative is to give the cb function both pointers, old and new
and have it do its thing.

Yet another option is to split the update side into helper functions
just like you did below for the read side.

> smp_wmb();
> lf->tail++;
> spin_unlock(&lock->write_lock);
> }
>
> static
> unsigned int foo_read_begin(struct latchfoo *lf)
> {
> unsigned int ret;
>
> ret = ACCESS_ONCE(lf->tail);
> smp_rmb();
> return ret;
> }
>
> static
> struct foo *foo_read_get(struct latchfoo *lf, unsigned int tail)
> {
> return &lf->data[tail & 1];
> }
>
> static
> int foo_read_retry(struct latchfoo *lf, unsigned int tail)
> {
> smp_rmb();
> return (ACCESS_ONCE(lf->head) - tail >= 2);
> }
>
> Comments are welcome,

Yeah this would work. The foo_read_begin() and foo_read_get() split is a
bit awkward but C doesn't really encourage us to do any better.