public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Christoph Lameter <cl@linux.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Gilad Ben-Yossef <gilad@benyossef.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mike Frysinger <vapier@gentoo.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] Restrict kernel spawning of threads to a specified set of cpus.
Date: Thu, 12 Sep 2013 08:39:22 -0700	[thread overview]
Message-ID: <20130912153922.GP3966@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130912151102.GB23839@somewhere>

On Thu, Sep 12, 2013 at 05:11:04PM +0200, Frederic Weisbecker wrote:
> On Thu, Sep 12, 2013 at 02:52:56PM +0000, Christoph Lameter wrote:
> > On Thu, 12 Sep 2013, Frederic Weisbecker wrote:
> > 
> > > > > Ok but you can change the affinity of a kthread from userspace, as
> > > > > long as you define a cpu set that is among that kthread's cpus allowed.
> > > >
> > > > Ok but at that point kthread has already spawned a lot of kernel threads.
> > > >
> > > > The same is true for init and kmod.
> > > >
> > >
> > > Ok but then we just need to set the affinity of all these kthreads.
> > > A simple lookup on /proc/[0-9]+/ should do the trick.
> > 
> > Yea but the kernel option makes it easy. No extras needed. Kernel brings
> > it up user space cleanly configured and ready to go.
> 
> Ok but really that's just two lines of bash. I really wish we don't complicate
> core kernel code for that.

OK, I will bite...  How do you handle the case where you have collected
all the kthreads, one of the kthreads spawns another kthread, then you
set affinity on the collected kthreads, which does not include the newly
spawned one?

							Thanx, Paul

> I think we all agree that the big issue here is that CPU isolation requires to set up
> a fragmented set of features and it's not at all obvious to do it correctly: full dynticks,
> rcu nocbs, kthreads affinity, timer_list, hrtimers, workqueues, IPIs, etc...
> 
> So IMHO what is missing is a reliable userspace tool that can handle all that: do
> the checks on pre-requirements, handle the kthreads and even user task affinity, tweak
> some sysctl stuffs to turn off features that generate noise, etc...
> 
> > This also allows us to cleanup kernel uses of cpumasks in such a way that
> > proper thread placement for various other uses (reclaim f.e. kswpad) is
> > possible.
> 
> Same here, a central tool should be able to solve that.
> 


  parent reply	other threads:[~2013-09-12 15:39 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 20:07 [RFC] Restrict kernel spawning of threads to a specified set of cpus Christoph Lameter
2013-09-10  6:05 ` Gilad Ben-Yossef
2013-09-10  6:47   ` Mike Galbraith
2013-09-10  6:59     ` Gilad Ben-Yossef
2013-09-10  7:26       ` Mike Galbraith
2013-09-10  7:56         ` Gilad Ben-Yossef
2013-09-10  8:53           ` Mike Galbraith
2013-09-10 21:10           ` Christoph Lameter
2013-09-11  3:20             ` Mike Galbraith
2013-09-11 14:21               ` Christoph Lameter
2013-09-11 14:53                 ` Mike Galbraith
2013-09-11 16:56                   ` Christoph Lameter
2013-09-11 21:36                 ` Frederic Weisbecker
2013-09-12  3:30                   ` Mike Galbraith
2013-09-10 21:08   ` Christoph Lameter
2013-09-10  7:39 ` Rob Landley
2013-09-10 21:11   ` Christoph Lameter
2013-09-11 22:02 ` Frederic Weisbecker
2013-09-12 14:10   ` Christoph Lameter
2013-09-12 14:16     ` Frederic Weisbecker
2013-09-12 14:22       ` Christoph Lameter
2013-09-12 14:31         ` Frederic Weisbecker
2013-09-12 14:52           ` Christoph Lameter
2013-09-12 15:11             ` Frederic Weisbecker
2013-09-12 15:32               ` Christoph Lameter
2013-09-12 18:45                 ` Frederic Weisbecker
2013-09-12 15:39               ` Paul E. McKenney [this message]
2013-09-12 18:35                 ` Frederic Weisbecker
2013-09-12 18:51                   ` Paul E. McKenney
2013-09-15 13:53                   ` Gilad Ben-Yossef
     [not found]               ` <alpine.DEB.2.02.1309121030390.21473@gentwo.org>
2013-09-12 15:42                 ` Christoph Lameter
2013-09-12 18:30                   ` Frederic Weisbecker
2013-09-13  9:25                     ` Peter Zijlstra
2013-09-13 13:54                       ` Christoph Lameter
2013-09-13 14:40                         ` Peter Zijlstra
2013-09-13 15:15                           ` Christoph Lameter
     [not found]                           ` <alpine.DEB.2.02.1309131010480.26487@gentwo.org>
2013-09-13 15:40                             ` Christoph Lameter
2013-09-16  6:02                               ` Peter Zijlstra
2013-09-13 13:45                     ` Christoph Lameter
2013-09-13 14:04                       ` Frederic Weisbecker
2013-09-13 14:25                         ` Christoph Lameter
2013-09-15 13:47       ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912153922.GP3966@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=fweisbec@gmail.com \
    --cc=gilad@benyossef.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox