* [PATCH] Staging: Remove a few superfluous braces
@ 2013-09-07 22:51 Sean Williams
2013-09-09 9:22 ` Ian Abbott
2013-09-12 21:50 ` [PATCH] Staging: comedi: ni_at_a2150: " Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Sean Williams @ 2013-09-07 22:51 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh, devel, linux-kernel; +Cc: Sean Williams
Please don't flame me :) I'm getting my feet wet with kernel contribution.
One example I saw in a video by GKH suggested cleaning up coding style as a good first commit.
Signed-off-by: Sean Williams <unixed@gmail.com>
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c b/drivers/staging/comedi/drivers/ni_at_a2150.c
index 2512ce8..c77d343 100644
--- a/drivers/staging/comedi/drivers/ni_at_a2150.c
+++ b/drivers/staging/comedi/drivers/ni_at_a2150.c
@@ -684,13 +684,12 @@ static int a2150_set_chanlist(struct comedi_device *dev,
devpriv->config_bits |= CHANNEL_BITS(0x4 | start_channel);
break;
case 2:
- if (start_channel == 0) {
+ if (start_channel == 0)
devpriv->config_bits |= CHANNEL_BITS(0x2);
- } else if (start_channel == 2) {
+ else if (start_channel == 2)
devpriv->config_bits |= CHANNEL_BITS(0x3);
- } else {
+ else
return -1;
- }
break;
case 4:
devpriv->config_bits |= CHANNEL_BITS(0x1);
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: Remove a few superfluous braces
2013-09-07 22:51 [PATCH] Staging: Remove a few superfluous braces Sean Williams
@ 2013-09-09 9:22 ` Ian Abbott
2013-09-12 21:50 ` [PATCH] Staging: comedi: ni_at_a2150: " Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2013-09-09 9:22 UTC (permalink / raw)
To: Sean Williams
Cc: Ian Abbott, hsweeten@visionengravers.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
On 2013-09-07 23:51, Sean Williams wrote:
> Please don't flame me :) I'm getting my feet wet with kernel contribution.
> One example I saw in a video by GKH suggested cleaning up coding style as a good first commit.
>
> Signed-off-by: Sean Williams <unixed@gmail.com>
Fair enough.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: comedi: ni_at_a2150: Remove a few superfluous braces
2013-09-07 22:51 [PATCH] Staging: Remove a few superfluous braces Sean Williams
2013-09-09 9:22 ` Ian Abbott
@ 2013-09-12 21:50 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-09-12 21:50 UTC (permalink / raw)
To: Sean Williams; +Cc: abbotti, hsweeten, devel, linux-kernel
On Sat, Sep 07, 2013 at 03:51:34PM -0700, Sean Williams wrote:
> Please don't flame me :) I'm getting my feet wet with kernel contribution.
Why would we flame anyone for sending us patches?
It's as if we are bunch of scary people or something...
Nice job with this, I'll queue it up after 3.12-rc1 is out.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-12 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-07 22:51 [PATCH] Staging: Remove a few superfluous braces Sean Williams
2013-09-09 9:22 ` Ian Abbott
2013-09-12 21:50 ` [PATCH] Staging: comedi: ni_at_a2150: " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox