From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kay Sievers <kay@vrfy.org>
Cc: Tom Gundersen <teg@jklm.no>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Minchan Kim <minchan@kernel.org>,
devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.
Date: Thu, 12 Sep 2013 15:43:01 -0700 [thread overview]
Message-ID: <20130912224301.GA21415@kroah.com> (raw)
In-Reply-To: <CAPXgP11XKqsQB96t=NPB1sQT5ppxUOnz4FZyFtXsE0PyF2jArA@mail.gmail.com>
On Mon, Sep 09, 2013 at 06:41:48PM +0200, Kay Sievers wrote:
> On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen <teg@jklm.no> wrote:
> > Hi Konrad,
> >
> > The above commit (c70bda9 in mainline) doesn't appear to work for me.
> > I.e., depmod does not create an entry in modules.devname and hence no
> > device node is created on boot.
> >
> > If I understand correctly, you'd also need to create the correct
> > "char-major-<MAJOR>-<MINOR>" alias. But I don't really see how this is
> > meant to work as I thought zram only created /dev/zramX type device
> > nodes, and not /dev/zram, or am I missing something?
>
> Please just remove it. "devname" is meant to be used for
> single-instance devices with a static dev_t, never for things like
> zramX.
>
> It will not do anything useful here, it does nothing really without a
> statically assigned dev_t, and it should not be used for devices of
> this kind anyway.
I'll revert this after 3.12-rc1 is out, thanks,
greg k-h
prev parent reply other threads:[~2013-09-12 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:58 [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram Tom Gundersen
2013-09-09 16:41 ` Kay Sievers
2013-09-12 22:43 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912224301.GA21415@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=kay@vrfy.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox