* [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.
@ 2013-09-09 15:58 Tom Gundersen
2013-09-09 16:41 ` Kay Sievers
0 siblings, 1 reply; 3+ messages in thread
From: Tom Gundersen @ 2013-09-09 15:58 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Greg Kroah-Hartman, Minchan Kim, devel, LKML, Kay Sievers
Hi Konrad,
The above commit (c70bda9 in mainline) doesn't appear to work for me.
I.e., depmod does not create an entry in modules.devname and hence no
device node is created on boot.
If I understand correctly, you'd also need to create the correct
"char-major-<MAJOR>-<MINOR>" alias. But I don't really see how this is
meant to work as I thought zram only created /dev/zramX type device
nodes, and not /dev/zram, or am I missing something?
Cheers,
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.
2013-09-09 15:58 [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram Tom Gundersen
@ 2013-09-09 16:41 ` Kay Sievers
2013-09-12 22:43 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Kay Sievers @ 2013-09-09 16:41 UTC (permalink / raw)
To: Tom Gundersen
Cc: Konrad Rzeszutek Wilk, Greg Kroah-Hartman, Minchan Kim, devel,
LKML
On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen <teg@jklm.no> wrote:
> Hi Konrad,
>
> The above commit (c70bda9 in mainline) doesn't appear to work for me.
> I.e., depmod does not create an entry in modules.devname and hence no
> device node is created on boot.
>
> If I understand correctly, you'd also need to create the correct
> "char-major-<MAJOR>-<MINOR>" alias. But I don't really see how this is
> meant to work as I thought zram only created /dev/zramX type device
> nodes, and not /dev/zram, or am I missing something?
Please just remove it. "devname" is meant to be used for
single-instance devices with a static dev_t, never for things like
zramX.
It will not do anything useful here, it does nothing really without a
statically assigned dev_t, and it should not be used for devices of
this kind anyway.
Thanks,
Kay
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram.
2013-09-09 16:41 ` Kay Sievers
@ 2013-09-12 22:43 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2013-09-12 22:43 UTC (permalink / raw)
To: Kay Sievers
Cc: Tom Gundersen, Konrad Rzeszutek Wilk, Minchan Kim, devel, LKML
On Mon, Sep 09, 2013 at 06:41:48PM +0200, Kay Sievers wrote:
> On Mon, Sep 9, 2013 at 5:58 PM, Tom Gundersen <teg@jklm.no> wrote:
> > Hi Konrad,
> >
> > The above commit (c70bda9 in mainline) doesn't appear to work for me.
> > I.e., depmod does not create an entry in modules.devname and hence no
> > device node is created on boot.
> >
> > If I understand correctly, you'd also need to create the correct
> > "char-major-<MAJOR>-<MINOR>" alias. But I don't really see how this is
> > meant to work as I thought zram only created /dev/zramX type device
> > nodes, and not /dev/zram, or am I missing something?
>
> Please just remove it. "devname" is meant to be used for
> single-instance devices with a static dev_t, never for things like
> zramX.
>
> It will not do anything useful here, it does nothing really without a
> statically assigned dev_t, and it should not be used for devices of
> this kind anyway.
I'll revert this after 3.12-rc1 is out, thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-12 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 15:58 [BUG?] staging: zram: Add auto loading of module if user opens /dev/zram Tom Gundersen
2013-09-09 16:41 ` Kay Sievers
2013-09-12 22:43 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox