From: Peter Chen <peter.chen@freescale.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async
Date: Fri, 13 Sep 2013 09:55:03 +0800 [thread overview]
Message-ID: <20130913015502.GA20706@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <87ioy536mu.fsf@rustcorp.com.au>
On Fri, Sep 13, 2013 at 10:00:33AM +0930, Rusty Russell wrote:
> Peter Chen <peter.chen@freescale.com> writes:
> > Currently, if module's refcount is not zero during the unload,
> > it waits there until the user decreases that refcount.
>
> Hi Peter,
>
> In practice userspace uses O_NONBLOCK. In fact, I've been
> thinking of removing the blocking case altogether, since it's not really
> what people want.
>
> That would solve your problem and make the code simpler. Thoughts?
>
So, it will like "Force unload" case, right?
If it is the case, it is better have a warning message to indicate
some users are still using it, since there may null pointer
dereference when the user module has unloaded, and the end user
can understand it may be triggered by wrong module unload sequence.
Thanks.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-09-13 1:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 3:14 [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async Peter Chen
2013-09-13 0:30 ` Rusty Russell
2013-09-13 1:55 ` Peter Chen [this message]
2013-09-13 2:08 ` Lucas De Marchi
2013-09-16 3:47 ` Rusty Russell
2013-09-17 22:59 ` Lucas De Marchi
2014-01-25 14:54 ` Jan Engelhardt
2014-01-27 11:45 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913015502.GA20706@shlinux1.ap.freescale.net \
--to=peter.chen@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox