From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org, "'Samuel Ortiz'" <sameo@linux.intel.com>
Subject: Re: [PATCH V2] mfd: timberdale: remove unnecessary pci_set_drvdata()
Date: Fri, 13 Sep 2013 08:07:51 +0100 [thread overview]
Message-ID: <20130913070751.GS11227@lee--X1> (raw)
In-Reply-To: <000401ceb028$4cb42d60$e61c8820$%han@samsung.com>
On Fri, 13 Sep 2013, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL. It also removes unnecessary label such
> as 'err_request'.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v1:
> - Removed unnecessary label such as 'err_request'.
>
> drivers/mfd/timberdale.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
Looks fine to me now.
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-13 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:41 [PATCH 1/3] mfd: lpc_ich: remove unnecessary pci_set_drvdata() Jingoo Han
2013-09-12 6:43 ` [PATCH 2/3] mfd: sm501: " Jingoo Han
2013-09-12 15:11 ` Lee Jones
2013-09-12 6:44 ` [PATCH 3/3] mfd: timberdale: " Jingoo Han
2013-09-12 15:10 ` Lee Jones
2013-09-13 2:23 ` [PATCH V2] " Jingoo Han
2013-09-13 7:07 ` Lee Jones [this message]
2013-09-12 15:09 ` [PATCH 1/3] mfd: lpc_ich: " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913070751.GS11227@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox