From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: linux-tip-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, paulus@samba.org, hpa@zytor.com,
peterz@infradead.org, efault@gmx.de, fweisbec@gmail.com,
adrian.hunter@intel.com, dsahern@gmail.com, tglx@linutronix.de
Subject: Re: perf/compat: Sharpen the libaudit dependencies test
Date: Sat, 14 Sep 2013 07:49:06 +0200 [thread overview]
Message-ID: <20130914054906.GA364@gmail.com> (raw)
In-Reply-To: <20130913192051.GA26865@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Thu, Sep 12, 2013 at 03:27:06PM +0200, Ingo Molnar escreveu:
> > There are older libaudit versions that don't have an audit_errno_to_name()
> > method, resulting in a builtin-trace.c build error:
> >
> > builtin-trace.c: In function ‘trace__sys_exit’:
> > builtin-trace.c:794: warning: implicit declaration of function ‘audit_errno_to_name’
> >
> > Expand the libaudit test to detect this.
>
> Lets sharpen it a bit more ;-)
>
> CHK libaudit
> <stdin>: In function ‘main’:
> <stdin>:5:9: error: ‘error’ undeclared (first use in this function)
> <stdin>:5:9: note: each undeclared identifier is reported only once for each function it appears in
> <stdin>:5:15: error: expected ‘)’ before ‘message’
> make: Entering directory `/home/git/linux/tools/perf'
> config/Makefile:238: No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev
>
> We need this folded in to buind it, so that the test works:
>
> diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
> index 5608add..7f550c1 100644
> --- a/tools/perf/config/feature-tests.mak
> +++ b/tools/perf/config/feature-tests.mak
> @@ -210,7 +210,7 @@ define SOURCE_LIBAUDIT
>
> int main(void)
> {
> - printf("error message: %s\n", audit_errno_to_name(0));
> + printf(\"error message: %s\n\", audit_errno_to_name(0));
indeed, I only tested that it turned the feature off :-/
Thanks,
Ingo
next prev parent reply other threads:[~2013-09-14 5:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 10:09 [tip:perf/core] perf trace: Simplify sys_exit return printing tip-bot for Arnaldo Carvalho de Melo
2013-09-12 13:27 ` perf/compat: Sharpen the libaudit dependencies test Ingo Molnar
2013-09-13 19:20 ` Arnaldo Carvalho de Melo
2013-09-14 5:49 ` Ingo Molnar [this message]
2013-09-20 9:55 ` [tip:perf/urgent] perf tools: " tip-bot for Ingo Molnar
2013-09-12 13:29 ` perf/compat: Fill in new definitions for madvise()/mmap() flags Ingo Molnar
2013-09-20 9:55 ` [tip:perf/urgent] perf tools: Fill in new definitions for madvise ()/mmap() flags tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130914054906.GA364@gmail.com \
--to=mingo@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox