From: Oleg Nesterov <oleg@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: viro@zeniv.linux.org.uk, rostedt@goodmis.org, fweisbec@gmail.com,
mingo@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmod: Check for NULL at call_usermodehelper_exec().
Date: Sun, 15 Sep 2013 19:34:56 +0200 [thread overview]
Message-ID: <20130915173456.GA16204@redhat.com> (raw)
In-Reply-To: <201309160226.DGH90134.QLSFtOJOOMFHVF@I-love.SAKURA.ne.jp>
Argh...
Tetsuo, I am sorry. Not only I am stupid, I managed to confuse you.
On 09/16, Tetsuo Handa wrote:
>
> Acked-by: Oleg Nesterov <oleg@redhat.com>
I tried to ack you previous version which I wrongly blamed ;)
However, I agree with this version as well. Feel free to use
either one, you have my ack in any case.
Sorry to all for noise and confusion.
> ---
> kernel/kmod.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/kmod.c b/kernel/kmod.c
> index fb32636..a962470 100644
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -571,6 +571,10 @@ int call_usermodehelper_exec(struct subprocess_info *sub_info, int wait)
> DECLARE_COMPLETION_ONSTACK(done);
> int retval = 0;
>
> + if (!sub_info->path) {
> + call_usermodehelper_freeinfo(sub_info);
> + return -ENOENT;
> + }
> helper_lock();
> if (!khelper_wq || usermodehelper_disabled) {
> retval = -EBUSY;
> --
> 1.7.1
next prev parent reply other threads:[~2013-09-15 17:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-14 7:32 [PATCH] argv_split: Return NULL if argument contains no non-whitespace Tetsuo Handa
2013-09-14 15:41 ` Oleg Nesterov
2013-09-15 0:10 ` [PATCH] argv_split: Return NULL if argument contains nonon-whitespace Tetsuo Handa
2013-09-15 14:23 ` [PATCH] kmod: Check for NULL at call_usermodehelper_exec() Tetsuo Handa
2013-09-15 16:31 ` Oleg Nesterov
2013-09-15 17:02 ` Tetsuo Handa
2013-09-15 17:15 ` Oleg Nesterov
2013-09-15 17:26 ` Tetsuo Handa
2013-09-15 17:34 ` Oleg Nesterov [this message]
2013-09-23 21:12 ` Tetsuo Handa
2013-09-23 21:30 ` Andrew Morton
2013-09-24 14:58 ` Tetsuo Handa
2013-09-15 16:26 ` [PATCH] argv_split: Return NULL if argument contains nonon-whitespace Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130915173456.GA16204@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox