public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sched: tweak comment for sched_info_depart
@ 2013-09-16  8:30 Michael S. Tsirkin
  2013-09-16 14:07 ` [tip:sched/urgent] sched: Fix " tip-bot for Michael S. Tsirkin
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2013-09-16  8:30 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ingo Molnar, Peter Zijlstra, Michael S. Tsirkin,
	Frederic Weisbecker, KOSAKI Motohiro

sched_info_depart seems to be only called from sched_info_switch,
so only on involuntary task switch.
Tweak comment to match.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 kernel/sched/stats.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
index 891ccab..2e63fc7 100644
--- a/kernel/sched/stats.h
+++ b/kernel/sched/stats.h
@@ -115,8 +115,9 @@ static inline void sched_info_queued(struct rq *rq, struct task_struct *t)
 }
 
 /*
- * Called when a process ceases being the active-running process, either
- * voluntarily or involuntarily.  Now we can calculate how long we ran.
+ * Called when a process ceases being the active-running process involuntarily
+ * due, typically, to expiring its time slice (this may also be called when
+ * switching to the idle task).  Now we can calculate how long we ran.
  * Also, if the process is still in the TASK_RUNNING state, call
  * sched_info_queued() to mark that it has now again started waiting on
  * the runqueue.
-- 
MST

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:sched/urgent] sched: Fix comment for sched_info_depart
  2013-09-16  8:30 [PATCH] sched: tweak comment for sched_info_depart Michael S. Tsirkin
@ 2013-09-16 14:07 ` tip-bot for Michael S. Tsirkin
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Michael S. Tsirkin @ 2013-09-16 14:07 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, hpa, mingo, mst, peterz, fweisbec, tglx,
	kosaki.motohiro

Commit-ID:  13b62e46d5407c7d619aea1dc9c3e0991b631b57
Gitweb:     http://git.kernel.org/tip/13b62e46d5407c7d619aea1dc9c3e0991b631b57
Author:     Michael S. Tsirkin <mst@redhat.com>
AuthorDate: Mon, 16 Sep 2013 11:30:36 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 16 Sep 2013 11:18:34 +0200

sched: Fix comment for sched_info_depart

sched_info_depart seems to be only called from
sched_info_switch(), so only on involuntary task switch.

Fix the comment to match.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Link: http://lkml.kernel.org/r/20130916083036.GA1113@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/sched/stats.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/stats.h b/kernel/sched/stats.h
index 5aef494..c7edee7 100644
--- a/kernel/sched/stats.h
+++ b/kernel/sched/stats.h
@@ -104,8 +104,9 @@ static inline void sched_info_queued(struct task_struct *t)
 }
 
 /*
- * Called when a process ceases being the active-running process, either
- * voluntarily or involuntarily.  Now we can calculate how long we ran.
+ * Called when a process ceases being the active-running process involuntarily
+ * due, typically, to expiring its time slice (this may also be called when
+ * switching to the idle task).  Now we can calculate how long we ran.
  * Also, if the process is still in the TASK_RUNNING state, call
  * sched_info_queued() to mark that it has now again started waiting on
  * the runqueue.

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-09-16 14:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16  8:30 [PATCH] sched: tweak comment for sched_info_depart Michael S. Tsirkin
2013-09-16 14:07 ` [tip:sched/urgent] sched: Fix " tip-bot for Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox