From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
Wang Shilong <wangshilong1991@gmail.com>
Subject: Re: [PATCH 1/4 v2] mfd: add STw481x driver
Date: Mon, 16 Sep 2013 12:06:14 +0100 [thread overview]
Message-ID: <20130916110614.GK3999@lee--X1> (raw)
In-Reply-To: <20130916104009.GA29403@sirena.org.uk>
On Mon, 16 Sep 2013, Mark Brown wrote:
> On Mon, Sep 16, 2013 at 10:19:56AM +0100, Lee Jones wrote:
>
> > Can't you just NULL .id_table?
>
> > Here's the code which would use it:
> > > /* match on an id table if there is one */
> > > if (driver->id_table)
> > > return i2c_match_id(driver->id_table, client) != NULL;
>
> > Matching for "dummy" will just waste cycles.
>
> i2c_device_probe() will return -ENODEV if id_table is NULL before we get
> to actually matching. We could remove that check though...
Unless there will be any repercussions that I am naive to I think that
sounds suitable. Any volunteers?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-16 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-13 17:54 [PATCH 1/4 v2] mfd: add STw481x driver Linus Walleij
2013-09-16 9:19 ` Lee Jones
2013-09-16 10:40 ` Mark Brown
2013-09-16 11:06 ` Lee Jones [this message]
2013-09-16 12:44 ` Linus Walleij
2013-09-16 13:51 ` Mark Brown
2013-09-16 15:21 ` Wolfram Sang
2013-09-16 15:34 ` Lee Jones
2013-09-16 16:00 ` Wolfram Sang
2013-09-16 16:05 ` Lee Jones
2013-09-16 16:24 ` Mark Brown
2013-09-17 8:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916110614.GK3999@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=wangshilong1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox